math: enable modular IIR, minor update for FIR #9848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
status: waiting for #9886 for improved test coverage |
lyakh
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
mmaka1,
plbossart and
singalsu
as code owners
Collaborator
Author
|
SOFCI TEST |
kv2019i
approved these changes
Mar 19, 2025
| set(df1 ../iir_df1.c ../iir_df1_generic.c ../iir_df1_hifi3.c ../iir_df1_hifi4.c ../iir_df1_hifi5.c) | ||
| else() | ||
| set(df1 "") | ||
| endif() |
Collaborator
There was a problem hiding this comment.
No need to change this PR, but please take a look at https://github.com/orgs/thesofproject/discussions/9899 and join the effort (for new files at least).
Collaborator
Author
There was a problem hiding this comment.
@kv2019i PTL didn't test... So, instead of re-testing, let me fix this and re-push
lgirdwood
approved these changes
Mar 19, 2025
Enable building IIR support library as a LLEXT module. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
fir_common.c is only needed for modular LLEXT builds, move it to the fir_llext/ directory. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
PTL didn't test... |
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
CI: the only failure is in alsabat test on MTL HDA https://sof-ci.01.org/sofpr/PR9848/build11683/devicetest/index.html?model=MTLP_RVP_HDA&testcase=check-alsabat-headset-capture-997 |
lgirdwood
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable building further parts of the Maths library as LLEXT modules, this does it for the IIR code.
So far a draft, waiting for the PTL support to work with LLEXT openmodules