Update waves codec integration for Zephyr production builds #9820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "group" variable is set but unused, causing a -Werror build failure with Zephyr. Signed-off-by: Andy Ross <andyross@google.com>
Include the proprietary static library when not building the stub, do a little reorganization of the cmake code to reduce duplication and clarify things a bit. Maybe. CMake code doesn't clean up very well. Signed-off-by: Andy Ross <andyross@google.com>
andyross
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
lyakh,
mmaka1 and
plbossart
as code owners
Contributor
|
johnylin76
approved these changes
Feb 9, 2025
lyakh
reviewed
Feb 10, 2025
| ${WAVES_DIR}/maxx_stub.c) | ||
| else() | ||
| zephyr_library_import(waves_codec | ||
| ${sof_top_dir}/third_party/lib/libMaxxChrome.a) |
Collaborator
There was a problem hiding this comment.
do you think it would also be good to enable modular build with the library?
Contributor
Author
There was a problem hiding this comment.
Undeniably, I just don't know how the llext stuff works yet and was afraid to break anything. :)
Member
There was a problem hiding this comment.
That can be done as stage 2 - no reason to block this PR today.
kv2019i
approved these changes
Feb 10, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Minor comment inline, but no blockers.
| else() | ||
| zephyr_library_sources(${WAVES_DIR}/waves.c) | ||
| if(CONFIG_WAVES_CODEC_STUB) | ||
| zephyr_library_sources_ifdef(CONFIG_WAVES_CODEC_STUB |
Collaborator
There was a problem hiding this comment.
This looks a bit weird with CONFIG_WAVES_CODEC_STUB tested both at LL1151 and then 1152, but should work still.
lgirdwood
approved these changes
Feb 10, 2025
| ${WAVES_DIR}/maxx_stub.c) | ||
| else() | ||
| zephyr_library_import(waves_codec | ||
| ${sof_top_dir}/third_party/lib/libMaxxChrome.a) |
Member
There was a problem hiding this comment.
That can be done as stage 2 - no reason to block this PR today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't including the needed third party library. Also rework it a little to make the cmake a little less of a mess. Not sure I actually improved things, but I tried.
Also one trivial warning fixup I stumbled on with a variant xt-clang.