Skip to content

mic_privacy: initial implementation #9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 4 commits into from
Mar 11, 2025
Merged

mic_privacy: initial implementation #9788

lgirdwood merged 4 commits into from
Mar 11, 2025

Conversation

@mbukowsk
Copy link
Contributor

@mbukowsk mbukowsk commented Jan 20, 2025

Audio privacy feature allows end user to directly
control if user space applications receive actual
data from input devices (microphones). The control
is bypassing application level settings or operating
system controls (like audio endpoint volume).

ujfalusi
ujfalusi reviewed Jan 21, 2025
View reviewed changes
ujfalusi
ujfalusi reviewed Jan 21, 2025
View reviewed changes
ujfalusi
ujfalusi reviewed Jan 21, 2025
View reviewed changes
lyakh
lyakh reviewed Jan 21, 2025
View reviewed changes
src/audio/mic_privacy_manager/mic_privacy_manager.c Outdated
return mic_privacy_api->get_dma_data_zeroing_link_select();
}
//hardcoded for FW_MANAGED
return 0xFFFFFFFF;
Copy link
Collaborator

@lyakh lyakh Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~0

lgirdwood
lgirdwood reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbukowsk can you confirm a high level overview of how it works when FW managed. i.e. I assume FW will send an IPC to SW when the mute is enabled/disabled ? What about Mic state at FW boot ?

src/include/sof/audio/mic_privacy_manager.h Outdated
#include <ipc4/base-config.h>
#include "../audio/copier/copier_gain.h"

#define ADSP_RTC_FREQUENCY 32768
Copy link
Member

@lgirdwood lgirdwood Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in Zephyr as its HW specific.

jsarha
jsarha reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@jsarha jsarha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bugs from me (the others already found the serious stuff), but couple of suggestions more.

@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch 6 times, most recently from 70c6211 to 37336ba Compare February 8, 2025 16:32
lyakh
lyakh reviewed Feb 10, 2025
View reviewed changes
@lgirdwood
Copy link
Member

lgirdwood commented Feb 10, 2025

@mbukowsk can you check CI, several failures. Thanks !

ujfalusi
ujfalusi requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbukowsk, the privacy_capabilities is configured to the wrong struct, that is going to case the host quite a bit of issues as it will not find it in hw_config and there will be two entries with the same ID in fw_config.

@lgirdwood
Copy link
Member

lgirdwood commented Feb 10, 2025

@mbukowsk, the privacy_capabilities is configured to the wrong struct, that is going to case the host quite a bit of issues as it will not find it in hw_config and there will be two entries with the same ID in fw_config.

@ujfalusi ok that's a blocker for kernel. Can you reply with what this should look like for kernel so @mbukowsk can copy.

@ujfalusi
Copy link
Contributor

ujfalusi commented Feb 11, 2025 •
edited
Loading

@mbukowsk, the privacy_capabilities is configured to the wrong struct, that is going to case the host quite a bit of issues as it will not find it in hw_config and there will be two entries with the same ID in fw_config.

@ujfalusi ok that's a blocker for kernel. Can you reply with what this should look like for kernel so @mbukowsk can copy.

No, this is a blocker for this PR.

The firmware places the IPC4_PRIVACY_CAPS_HW_CFG (as is a hardware configuration tuple with ID 11) into the FW_CFG (as is firmware configuration). The ID 11 is IPC4_MAX_ASTATE_COUNT_FW_CFG in firmware config.

These are different configurations, one is queried with SOF_IPC4_FW_PARAM_FW_CONFIG (basefw param 6), the other is SOF_IPC4_FW_PARAM_HW_CONFIG_GET (basefw param 7).

The IPC4_PRIVACY_CAPS_HW_CFG must be placed to the hardware config data in basefw_hw_config() and not in basefw_config() as this PR does.

The corresponding kernel patch is thesofproject/linux@7f00cf9

@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch 2 times, most recently from 37f0e45 to 764f2d8 Compare February 18, 2025 08:33
@abonislawski
Copy link
Member

abonislawski commented Feb 18, 2025

@ujfalusi @lyakh yeap its related. Both DMIC and mic privacy drivers enables the same IRQ so in debug build (linux CI) it can trigger assert for such check but works in normal build (internal CI).
Pushed test commit for west update to verify it.

ujfalusi
ujfalusi reviewed Feb 19, 2025
View reviewed changes
@ujfalusi
Copy link
Contributor

ujfalusi commented Feb 19, 2025

@abonislawski, we still have the crash on dmic start..

@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch 2 times, most recently from 524af57 to abe0df8 Compare February 20, 2025 08:51
@ujfalusi
Copy link
Contributor

ujfalusi commented Feb 21, 2025

SOFCI TEST

@abonislawski
Copy link
Member

abonislawski commented Feb 24, 2025 •
edited by kv2019i
Loading

Required Zephyr patches:

@lgirdwood lgirdwood added the DNM Do Not Merge tag label Feb 24, 2025
@lgirdwood
Copy link
Member

lgirdwood commented Feb 24, 2025

I've made this DNM until @abonislawski is ready with Zephyr patches merged.

@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch 2 times, most recently from 3843767 to 52c9e0d Compare February 25, 2025 07:53
@kv2019i
Copy link
Collaborator

kv2019i commented Mar 10, 2025

@abonislawski Zephyr PRs now merged, do you want to update to this PR?

@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch from 52c9e0d to 6a1fefa Compare March 10, 2025 11:49
@lgirdwood lgirdwood removed the DNM Do Not Merge tag label Mar 10, 2025
ujfalusi
ujfalusi reviewed Mar 11, 2025
View reviewed changes
@ujfalusi ujfalusi self-requested a review March 11, 2025 09:55
mbukowsk added 4 commits March 11, 2025 11:05
@mbukowsk @abonislawski
copier: gain: interface changes for setting gain params
99a46b4 
Change type of arguments for gain params setting functions.
DAI data struct is replaced by gain_params. Components other
than DAI can also use copier gain feature (eg. microphone privacy)

Signed-off-by: Michal Bukowski <michal.bukowski@intel.com>
@mbukowsk @abonislawski
mic_privacy: initial implementation
98f2c8d 
Audio privacy feature allows end user to directly
control if user space applications receive actual
data from input devices (microphones). The control
is bypassing application level settings or operating
system controls (like audio endpoint volume).

Signed-off-by: Michal Bukowski <michal.bukowski@intel.com>
@mbukowsk @abonislawski
ipc: added IPC SET_MIC_PRIVACY_FW_MANAGED_POLICY_MAS
36c058b 
Added empty implementation which always returns success

Signed-off-by: Michal Bukowski <michal.bukowski@intel.com>
@mbukowsk @abonislawski
mic_privacy: implement new IPC - SNDW_MIC_PRIVACY_HW_MANAGED_STATE_CH…
d3d665a 
…ANGE

SW sends this IPC when microphone privacy state is changed for
HW_MANAGED mode and SNDW interface.

Signed-off-by: Michal Bukowski <michal.bukowski@intel.com>
@abonislawski abonislawski force-pushed the mbukowsk-mic_privacy branch from 6a1fefa to d3d665a Compare March 11, 2025 10:05
@lgirdwood lgirdwood merged commit f6b7e77 into thesofproject:main Mar 11, 2025
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsarha jsarha jsarha left review comments

@lyakh lyakh lyakh left review comments

@kv2019i kv2019i kv2019i approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@ujfalusi ujfalusi ujfalusi approved these changes

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan iuliana-prodan is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@abonislawski abonislawski Awaiting requested review from abonislawski abonislawski is a code owner

@RanderWang RanderWang Awaiting requested review from RanderWang RanderWang is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski marcinszkudlinski is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mbukowsk @lgirdwood @ujfalusi @abonislawski @lyakh @kv2019i @jsarha