Topology2: add topologies for SDCA functions #9668
Conversation
bardliao
changed the title
|
CI test result #47819 looks good. |
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | ||
|
|
||
| #SDCA multi-function |
There was a problem hiding this comment.
@bardliao 2 questions:
- WHy is the BE ID important in the topology name?
- Why do you need to make HDMI optional based on the number of HDMI's in sof-hda-generic in the first patch when that you never modify NUM_HDMI for any of the HDMI topologies?
There was a problem hiding this comment.
@bardliao 2 questions:
- WHy is the BE ID important in the topology name?
The BE id in the topology should match the BE id exposed by the machine driver.
And BE id could be different between devices. For example, HDMI BE ids depends on how many SDW links are created and is PCH DMIC link is created.
- Why do you need to make HDMI optional based on the number of HDMI's in sof-hda-generic in the first patch when that you never modify NUM_HDMI for any of the HDMI topologies?
I would like to split the sof-hda-generic topology in the end. So, we need to make HDMI optional and remove the HDMI part from the generic sof-hda-generic topologies.
There was a problem hiding this comment.
if these are for sdca, should we name as so i.e. sof-sdca-function- as I assume SDCA means we dont need to set a platform ?
My assumption is we would have a sdca topology directory for all standard SDCA functions ?
There was a problem hiding this comment.
Yes, the sdca topologies are platform independent. In fact, I think only dmic and ssp topologies are platform dependent.
Currently, I don't put sdca topologies in a different folder.
bardliao
force-pushed
the
topology2-sdca
branch
from
a738b49 to
4a1aae6
Compare
|
@ranj063 good for you ? |
|
Let's wait for the kernel PR thesofproject/linux#5209 |
bardliao
force-pushed
the
topology2-sdca
branch
2 times, most recently
from
a0648fa to
781cc91
Compare
bardliao
force-pushed
the
topology2-sdca
branch
from
781cc91 to
b72b87a
Compare
|
@bardliao some conflicts. |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Let me tag with a -1 to ensure we have consensus on Linux side first thesofproject/linux#5209 -- the kernel PR doesn't have to be be merged, but let's just ensure we have a consensus first
bardliao
force-pushed
the
topology2-sdca
branch
from
b72b87a to
7ae4856
Compare
|
Rebased, and yes, we have to wait for thesofproject/linux#5209 and thesofproject/sof-docs#507 |
|
@kv2019i The kernel PR is merged. It is ready to merge now. |
This is a preparation commit for splitting topologies by devices. That means we will have generic hda topologies without HDMI. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add topologies for each sdca function. Linux kernel will load the corresponding topology per sdca function. The naming rule is sof-<platform>-<function>-<BE id> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
5 participants
Add topologies for each sdca function. Linux kernel will load the corresponding topology per sdca function. The naming rule is sof---