CI ONLY #9521
Closed
CI ONLY #9521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinszkudlinski
force-pushed
the
test1
branch
5 times, most recently
from
2110a40 to
37936d9
Compare
marcinszkudlinski
force-pushed
the
test1
branch
from
37936d9 to
d5a0785
Compare
marcinszkudlinski
force-pushed
the
test1
branch
3 times, most recently
from
ad1c8dd to
7af9547
Compare
marcinszkudlinski
force-pushed
the
test1
branch
2 times, most recently
from
ab31184 to
b96a987
Compare
marcinszkudlinski
force-pushed
the
test1
branch
from
b96a987 to
7629c56
Compare
Currently bind api call passes IPC4 header only. This commit extends API by adding pointers to sink/source of the entity that is being bound. Note that in pipeline 2.0 there's a possibility to bind a module to a module, therefore pointers to sink/src need to be provided instead of a pointer to a buffer Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Currently unbind api call passes IPC4 header only. This commit extends API by adding pointers to sink/source of the entity that is being bound. Note that in pipeline 2.0 there's a possibility to bind a module to a module, therefore pointers to sink/src need to be provided instead of a pointer to a buffer Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
This commit adds bind/unbind hook to sink/source API It is guaranteed that the hooks will be called on core that the API will be / was used on, what makes them a perfect place for cache operations needed at start/end of usage. Note that free method is not a good place for this, as in case of shared buffers it may happen on either of the cores the buffer connects Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Unbind used to be ignored for components in the same pipeline But there are some code that depends on the event and need to have it in all situations, i.e. dai_zephyr_unbind or cross-core DP connections in the same pipeline Propagate the event in all cases Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
unbind hook in buffer is guaranteed to be called on the core that was using the API. Free, however, may be called on other core Add cache invalidation, that must be called on core that was producing data (user of sink API) in unbind hook. Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
struct vmh_heap is a private structure and should not be used outside of regions_mm.c file structure moved Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
In case of cross core buffers a buffer may be allocated and freed by different core, depending on which component is deleted second. As all control structures of virtual heaps are stored in uncached aliases, there's no technical problems with allowing virtual heaps to work cross core. The only consideration is that in case of cross core allocate/free the cache invalidation MUST be performed on the core that was storing data. It is up to the memory user to ensure this Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
virtual heap may be called from multiple threads, all operations should be protected my mutex Spinlock used as race here is not very likely Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
struct sof_audio_buffer is a "base class" in a meaning of C++ of all buffers in SOF (currently comp_buffer and ring_buffer). Freeing of memory was based on indirect assumption that struct sof_audio_buffer is a very first field of the buffer structure this commit moves freeing of buffer to a method specific for each buffer type, enforcing that proper pointer will be used regardless of buffer structure Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.