Skip to content

vregion: Disable virtual regions on ACE 2.0 and earlier #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

vregion: Disable virtual regions on ACE 2.0 and earlier #10698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zephyr/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ config SOF_ZEPHYR_NO_SOF_CLOCK

Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default condition references ACE_VERSION_1_5 and ACE_VERSION_2_0, but these symbols are not defined anywhere in this repository’s Kconfig files. If they’re not provided by the external Zephyr tree, Kconfig will treat them as undefined (effectively n), making the condition equivalent to default y if ACE and/or emitting undefined-symbol warnings. Please confirm the correct Kconfig symbols for MTL/LNL in the build (or define them here) so the default actually disables vregions on ACE 1.5/2.0.

Suggested change
config ACE_VERSION_1_5
bool
default n
help
Hidden platform/version selector for ACE 1.5 based builds.
config ACE_VERSION_2_0
bool
default n
help
Hidden platform/version selector for ACE 2.0 based builds.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@jsarha jsarha Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this time AI is not hallucinating things that are not there, but it is not seeing things that are there in src/platform/Kconfig .

config SOF_VREGIONS
bool "Enable virtual memory regions"
default y if ACE
default y if ACE && !ACE_VERSION_1_5 && !ACE_VERSION_2_0
depends on ACE
help
Enable the virtual regions memory allocator for pipeline resource management.
Expand Down
Loading