-
Notifications
You must be signed in to change notification settings - Fork 349
[SKIP SOF-TEST] .github: disable windows Zephyr builds #10425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SKIP SOF-TEST] .github: disable windows Zephyr builds #10425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR disables Windows Zephyr builds in the GitHub Actions workflow due to upstream breaking changes and lack of maintainer support for the Windows build environment.
- Adds conditional
if: falseto disable thebuild-windowsjob - Updates comments explaining the reason for disabling Windows builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Example failures with current SOF main: |
7c44a5b to
396ed9e
Compare
The Windows Zephyr builds are failing due to changes in upstream Zephyr. We have no maintainer for these builds, so disabling the jobs for now. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
396ed9e to
a507a2b
Compare
|
Sorry for the noise. V3 passes yamllint, but compare-win-linux fails still. I don't fully understand the if logic in compare-windows-linux job definition and yamllint educated me that I cannot have two "if" cases for a single job. |
tmleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's not possible to skip this step only for PTL. I actively use a setup with Windows and it would be sad if it became unusable.
|
@tmleman wrote:
I sense a volunteer. :) Can you look at the failure? Any idea how to fix this in the github workflow? (UPDATE: not this PR, but the failrues we have with build-windows ). |
|
Windows build fixed, this no longer needed. |
The Windows Zephyr builds are failing due to changes in upstream Zephyr. We have no maintainer for these builds, so disabling the jobs for now.