Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Dec 10, 2025

The Windows Zephyr builds are failing due to changes in upstream Zephyr. We have no maintainer for these builds, so disabling the jobs for now.

Copilot AI review requested due to automatic review settings December 10, 2025 12:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables Windows Zephyr builds in the GitHub Actions workflow due to upstream breaking changes and lack of maintainer support for the Windows build environment.

  • Adds conditional if: false to disable the build-windows job
  • Updates comments explaining the reason for disabling Windows builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 10, 2025

Example failures with current SOF main:
https://github.com/thesofproject/sof/actions/runs/20082364368/job/57612214740?pr=10424

 [477/498] Generating kobject_prebuilt_hash_preprocessed.c
FAILED: [code=1] zephyr/kobject_prebuilt_hash_preprocessed.c D:/a/sof/sof/workspace/build-ptl/zephyr/kobject_prebuilt_hash_preprocessed.c 
C:\Windows\system32\cmd.exe /C "cd /D D:\a\sof\sof\workspace\build-ptl\zephyr && GPERF-NOTFOUND --output-file kobject_prebuilt_hash_preprocessed.c --multiple-iterations 10 kobject_prebuilt_hash.gperf"
'GPERF-NOTFOUND' is not recognized as an internal or external command,
operable program or batch file.
ninja: build stopped: subcommand failed.

@kv2019i kv2019i force-pushed the 202512-github-disable-win-builds branch from 7c44a5b to 396ed9e Compare December 10, 2025 12:17
The Windows Zephyr builds are failing due to changes in upstream
Zephyr. We have no maintainer for these builds, so disabling the jobs
for now.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202512-github-disable-win-builds branch from 396ed9e to a507a2b Compare December 10, 2025 13:08
@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 10, 2025

Sorry for the noise. V3 passes yamllint, but compare-win-linux fails still. I don't fully understand the if logic in compare-windows-linux job definition and yamllint educated me that I cannot have two "if" cases for a single job.

@kv2019i kv2019i marked this pull request as draft December 10, 2025 13:44
Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's not possible to skip this step only for PTL. I actively use a setup with Windows and it would be sad if it became unusable.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 10, 2025

@tmleman wrote:

I assume it's not possible to skip this step only for PTL. I actively use a setup with Windows and it would be sad if it became unusable.

I sense a volunteer. :) Can you look at the failure? Any idea how to fix this in the github workflow? (UPDATE: not this PR, but the failrues we have with build-windows ).

@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 17, 2025

Windows build fixed, this no longer needed.

@kv2019i kv2019i closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants