Skip to content

Conversation

@singalsu
Copy link
Collaborator

@singalsu singalsu commented Dec 5, 2025

This patch adds the proper blob speaker_default.txt that matches with UCMv2 blob speaker_default.bin.

The incorrect format blob generic_notebook_spoeaker.txt with no TLV header is removed.

This patch adds the proper blob speaker_default.txt that matches
with UCMv2 blob speaker_default.bin.

The incorrect format blob generic_notebook_spoeaker.txt with
no TLV header is removed.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu singalsu marked this pull request as ready for review December 5, 2025 09:37
Copilot AI review requested due to automatic review settings December 5, 2025 09:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects DRC (Dynamic Range Control) configuration files by adding the proper speaker_default.txt blob that matches the UCMv2 binary format and removing an incorrectly formatted generic_notebook_speaker.txt file that was missing the required TLV header.

Key Changes

  • Added new speaker_default.txt file with proper TLV header format (starting with 3,140,)
  • Removed incorrectly formatted generic_notebook_speaker.txt that lacked the TLV header

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/ctl/ipc4/drc/speaker_default.txt New file containing DRC blob with proper TLV header format matching UCMv2 binary
tools/ctl/ipc4/drc/generic_notebook_speaker.txt Removed incorrectly formatted DRC blob missing TLV header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JohnAZoidberg
Copy link

JohnAZoidberg commented Dec 5, 2025

That works, thanks!

[I] zoid@fedora ~/c/s/t/c/ipc4 (ctl_fix_drc_speaker_blob)> sof-ctl -c name='Post Mixer Analog Playback DRC bytes' -s drc/speaker_default.txt
Control size is 1024.
Applying configuration "drc/speaker_default.txt" into device hw:0 control name=Post Mixer Analog Playback DRC bytes.
3,140,877023059,0,108,50450433,0,0,0,0,108,0,0,0,0,1,3791650816,335544320,167772160,6442451,33954698,107374182,12228399,1969176,4292887072,5305422,137666458,81276115,7456540,4286019447,2062296,5,4423680,294359,2477728,622039,46513
Info: ABI mismatch: expecting: 0x00464f53, got: 0x34464f53
Success.
hdr: magic 0x34464f53
hdr: type 0
hdr: size 108 bytes
hdr: abi 3:29:1
3,140,877023059,0,108,50450433,0,0,0,0,108,0,0,0,0,1,3791650816,335544320,167772160,6442451,33954698,107374182,12228399,1969176,4292887072,5305422,137666458,81276115,7456540,4286019447,2062296,5,4423680,294359,2477728,622039,46513

[I] zoid@fedora ~/c/s/t/c/ipc4 (ctl_fix_drc_speaker_blob)> sof-ctl -c name='Post Mixer Analog Playback DRC bytes' -s drc/passthrough.txt
Control size is 1024.
Applying configuration "drc/passthrough.txt" into device hw:0 control name=Post Mixer Analog Playback DRC bytes.
3,140,877023059,0,108,50450433,0,0,0,0,108,0,0,0,0,0,3892314112,503316480,201326592,6442451,67748529,89478485,2030160,9723989,4285175934,33474947,575096676,24401431,7456540,4286019447,2062296,5,4423680,294359,2477728,622039,46513
Info: ABI mismatch: expecting: 0x00464f53, got: 0x34464f53
Success.
hdr: magic 0x34464f53
hdr: type 0
hdr: size 108 bytes
hdr: abi 3:29:1
3,140,877023059,0,108,50450433,0,0,0,0,108,0,0,0,0,0,3892314112,503316480,201326592,6442451,67748529,89478485,2030160,9723989,4285175934,33474947,575096676,24401431,7456540,4286019447,2062296,5,4423680,294359,2477728,622039,46513

@lgirdwood
Copy link
Member

Not tested by internal CI.

@lgirdwood lgirdwood merged commit e00764e into thesofproject:main Dec 5, 2025
37 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants