audio: ipc4: dai: pass correct blob size to dai driver #10416
Conversation
When converting to new dai_set_config() interface, incorrect size was passed. copier_cfg->gtw_cfg.config_length is in words, but dai_set_config() takes size in bytes. Fixes: b9fb0b4 ("audio: dai: Pass bespoke config size through dai_set_config chain") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the IPC4 DAI configuration where an incorrect size parameter was being passed to the dai_set_config() function. The issue arose from a misunderstanding of units: config_length is measured in words, but dai_set_config() expects the size in bytes.
- Converts the configuration length from words to bytes by shifting left by 2 (multiplying by 4)
- Adds a clarifying comment about the unit of
config_length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CI seems good. Unrelated mei0 error for https://sof-ci.01.org/sofpr/PR10416/build17832/devicetest/index.html?model=LNLM_RVP_NOCODEC&testcase=check-suspend-resume-with-capture-5 , same with the PTL test. Once review is ok, this is ready to go. |
|
Known issues in LNL/PTL jenkins test rounds. but the critical nocodec tests affected by this PR pass. Rerun some of the github flows, those also pass now. Proceeding with merge. |
3 participants
When converting to new dai_set_config() interface, incorrect size was passed. copier_cfg->gtw_cfg.config_length is in words, but dai_set_config() takes size in bytes.
Fixes: b9fb0b4 ("audio: dai: Pass bespoke config size through dai_set_config chain")