zephyr: alloc: fix L3 heap restore after power state change #10405
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix L3 heap restoration logic to ensure MMU mapping is always configured before restoring the heap state from l3_heap_copy. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
kv2019i
approved these changes
Dec 1, 2025
lgirdwood
approved these changes
Dec 1, 2025
serhiy-katsyuba-intel
approved these changes
Dec 1, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue in L3 heap restoration logic after power state changes by ensuring MMU mapping is always configured before attempting to restore the heap state from l3_heap_copy.
Key Changes:
- Restructured the conditional logic to always configure MMU mapping when
ace_imr_used()is true - Moved the
l3_heap_copyrestoration check inside theace_imr_used()block to occur after MMU setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmleman
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix L3 heap restoration logic to ensure MMU mapping is always configured before restoring the heap state from l3_heap_copy.