Skip to content

Conversation

@tmleman
Copy link
Contributor

@tmleman tmleman commented Dec 1, 2025

The math/advanced/functions unit test was merged after the refactor that removed CONFIG_SOF and introduced CONFIG_SOF_FULL_ZEPHYR_APPLICATION. This test was missing the CONFIG_SOF_FULL_ZEPHYR_APPLICATION=n setting required for ztest unit tests to build without pulling in full SOF dependencies.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the build configuration for the math/advanced/functions ztest unit test, which was merged after a refactor that replaced CONFIG_SOF with CONFIG_SOF_FULL_ZEPHYR_APPLICATION. The changes align this test with the new configuration pattern used by other ztest unit tests.

  • Added CONFIG_SOF_FULL_ZEPHYR_APPLICATION=n to prevent pulling in full SOF dependencies
  • Removed obsolete CONFIG_SOF_LOG_LEVEL compile definition

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/ztest/unit/math/advanced/functions/prj.conf Added CONFIG_SOF_FULL_ZEPHYR_APPLICATION=n to align with ztest configuration pattern
test/ztest/unit/math/advanced/functions/CMakeLists.txt Removed obsolete CONFIG_SOF_LOG_LEVEL compile definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The math/advanced/functions unit test was merged after the refactor that
removed CONFIG_SOF and introduced CONFIG_SOF_FULL_ZEPHYR_APPLICATION.
This test was missing the CONFIG_SOF_FULL_ZEPHYR_APPLICATION=n setting
required for ztest unit tests to build without pulling in full SOF
dependencies.

Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Copy link
Collaborator

@softwarecki softwarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kv2019i kv2019i merged commit 57075df into thesofproject:main Dec 1, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants