ipc4: Fix buffer use after free #10400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer has to be disconnected from both components before being freed. Buffer is usually freed at unbind. However, if unbind was not called before pipeline delete (e.g., because of a driver or test bug) buffer is freed at ipc_pipeline_module_free(). Without this fix buffer is freed without being disconnected from its source component and then several lines below at ipc_comp_free() the component disconnects itself from any buffers and so writes to already freed struct comp_buffer. This problem seems to be a regression introduced by this commit: 8aa90d6 Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
serhiy-katsyuba-intel
requested review from
abonislawski,
softwarecki and
tmleman
tmleman
approved these changes
Dec 1, 2025
Contributor
tmleman
left a comment
tmleman
left a comment
There was a problem hiding this comment.
Great catch!
BTW, the unit test failure is unrelated to this pull request.
abonislawski
approved these changes
Dec 1, 2025
softwarecki
approved these changes
Dec 1, 2025
lgirdwood
approved these changes
Dec 1, 2025
Collaborator
|
SOFCI TEST |
Collaborator
|
Jenkins builder hit a networking issue and sof-ci/jenkins/pr-build was stuff. Restarting.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer has to be disconnected from both components before being freed.
Buffer is usually freed at unbind. However, if unbind was not called before pipeline delete (e.g., because of a driver or test bug) buffer is freed at ipc_pipeline_module_free(). Without this fix buffer is freed without being disconnected from its source component and then several lines below at ipc_comp_free() the component disconnects itself from any buffers and so writes to already freed struct comp_buffer.
This problem seems to be a regression introduced by this commit: 8aa90d6