Tools: Topology: Add whole and DMIC fragment topologies for NVL #10375
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds DMIC fragment topology configurations for the NVL (Nova Lake) platform targeting ACE4.x. The changes enable multi-microphone beamformer and DRC pre-processing by setting DMIC0_ENHANCED_CAPTURE=true in the topology definitions.
Key Changes:
- Added new ACE4 topology target file with 8 DMIC topology variants (2ch and 4ch configurations with different ID assignments)
- Integrated the new ACE4 targets into the build system
- Configured NVL platform to use PTL configuration settings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace4.cmake | Defines 8 new DMIC topology configurations for NVL platform with 2-channel and 4-channel variants across different device IDs |
| tools/topology/topology2/production/CMakeLists.txt | Includes the new ACE4 topology targets in the build configuration |
| tools/topology/topology2/cavs-sdw.conf | Maps NVL platform to use PTL configuration files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This patch adds whole topologies and DMIC fragments for the NVL platform. The target is to use the existing and these added fragments, but for transition phase we still need the whole topologies. The list for ACE4.x is trimmed down from ACE3.x. The function topologies for DMIC have DMIC0_ENHANCED_CAPTURE=true added to enable multi-microphone beamformer and DRC pre-processing. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg_add_nvl_dmic_fragment
branch
from
1fd22c5 to
02bb00f
Compare
singalsu
changed the title
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Ack, good for me. @bardliao we need to remember to prune this list and remove any "non-function" topologies we do NOT want to ship in sof-bin upstream. Next release is in 2026, so there is time, but we just need to remember to follow-up. Once we release a topology, then it is nearly impossible to remove anymore (as this can break peoples' setups).
|
Topology changes not tested by "Internal Intel CI", ignoring these fails. |
3 participants
The list for ACE4.x is trimmed down version from ACE3.x. The function topologies for DMIC have DMIC0_ENHANCED_CAPTURE=true added to enable multi-microphone beamformer and DRC pre-processing.