audio: codec_adapter: Convert DAX module to use new module API #10363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all comp_data_blob_handler_new/free(), rmalloc(), bmalloc(), and rfree() calls to their module associated counterparts. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Converts the DAX module to use the new module API by replacing legacy memory and blob handler functions with their module-specific counterparts, ensuring proper resource management through the module context.
- Replaced legacy memory allocation/deallocation functions (rballoc, rzalloc, rfree) with module-specific equivalents (mod_balloc, mod_zalloc, mod_free)
- Updated blob handler functions to use mod_data_blob_handler_new/free instead of comp_data_blob_handler_new/free
- Modified dax_buffer_alloc and dax_buffer_release to accept processing_module parameter for API consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lgirdwood
approved these changes
Nov 12, 2025
lyakh
approved these changes
Nov 13, 2025
Member
|
@lrudyX I dont think this module is tested by Internal CI, good to go ? |
Contributor
Author
@lgirdwood , there is a in testbench using the DAX module, and at least runs succesfully also after this PR. |
Member
|
Merging. Not tested by internal CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all comp_data_blob_handler_new/free(), rmalloc(), bmalloc(), and rfree() calls to their module associated counterparts.