Skip to content

Conversation

@jsarha
Copy link
Contributor

@jsarha jsarha commented Nov 7, 2025

Remove CONFIG_ADSP_IMR_CONTEXT_SAVE=n from app/os_linux_overlay.conf.

This is a temporary remedy to overcome an issue we currently have in loading individual llext modules on second boot. The open-modules bundle apparently works Ok still.

Remove CONFIG_ADSP_IMR_CONTEXT_SAVE=n from app/os_linux_overlay.conf.

This is a temporary remedy to overcome an issue we currently have in
loading individual llext modules on second boot. The open-modules
bundle apparently works Ok still.

Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Copilot AI review requested due to automatic review settings November 7, 2025 11:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the configuration setting that disables ADSP IMR context save in the Linux overlay configuration. This change addresses a boot issue with individual llext module loading by allowing firmware state retention.

  • Removes CONFIG_ADSP_IMR_CONTEXT_SAVE=n configuration setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsarha ! This is a bit odd to have an empty file, but this allows to enable the Linux overlay in CI instances, and then submit a revert of this PR and get CI feedback before merge.

FYI @cgturner1

We do need to figure out some way to identify the overlay use in FW version. Upto now, the combination of SOF version and hw target, has been unique so any bug reports could have been tracked to a specific source/build configuration. With the overlay, this link is broken and we can't anymore figure out from kernel/FW logs, how the FW was built. I'll probably file a ticket for this.

Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed by #10360

@lyakh
Copy link
Collaborator

lyakh commented Nov 14, 2025

@jsarha should this be closed now that #10360 has been merged?

@jsarha
Copy link
Contributor Author

jsarha commented Nov 14, 2025

@jsarha should this be closed now that #10360 has been merged?

Yes.

@jsarha jsarha closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants