-
Notifications
You must be signed in to change notification settings - Fork 349
audio: codec_adapter: add llext support for dax #10331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch?
|
|
This change encounters following errors when we run on MTL platform machine: [ 51.125310] <err> llext: do_llext_load: Failed to allocate extension symbol table, ret -12
[ 51.125340] <err> lib_manager: llext_manager_link_single: linking failed: -12
[ 51.125346] <err> lib_manager: lib_manager_module_create: lib_manager_allocate_module() failed!
[ 51.125378] <err> ipc: ipc4_init_module_instance: error: failed to init module 1000 : 0
[ 51.125385] <err> ipc: ipc_cmd: ipc4: MODULE_MSG failed with err 104Seems like See See
I have no idea what the limitation is. |
8951b28 to
94b23f8
Compare
|
test this please |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm good to go ahead whilst we work on optimizing linking speed for larger modules
94b23f8 to
32b551c
Compare
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with "CONFIG_LLEXT_EXPERIMENTAL" warrants follow-up, but I don't think blocking this PR (given this is feature overlay specific to one platform).
I recommend adding inline comments to dax_overlay.conf for the less-than-obvious settings.
LLEXT support for dax. Signed-off-by: Jun Lai <jun.lai@dolby.com>
32b551c to
0b90585
Compare
|
@blin-dolby Hello, bin, please help to review this change, thx. |
No further comments, looks good. |
|
CI looks stuck- rerun |
|
SOFCI TEST |
|
The CI check failure does not appear to be caused by this change. The code that casue code style check failure is totally copied from |
Yes, the code style checker is too picky sometimes. Its advisory. |
LLEXT support for DAX.