Skip to content

module_adapter: generic: Clean up and optimize mod_free_all() #10316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Nov 3, 2025
Merged

module_adapter: generic: Clean up and optimize mod_free_all() #10316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/audio/module_adapter/module/generic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,22 +590,20 @@ void mod_free_all(struct processing_module *mod)
struct list_item *_list;

MEM_API_CHECK_THREAD(res);
/* Find which container keeps this memory */
list_for_item_safe(list, _list, &res->res_list) {
/* Free all contents found in used containers */
list_for_item(list, &res->res_list) {
struct module_resource *container =
container_of(list, struct module_resource, list);

free_contents(mod, container);
list_item_del(&container->list);
}

list_for_item_safe(list, _list, &res->free_cont_list) {
struct module_resource *container =
container_of(list, struct module_resource, list);

list_item_del(&container->list);
}

/*
* We do not need to remove the containers from res_list in
* the loop above or go through free_cont_list as all the
* containers are anyway freed in the loop below, and the list
* heads are reinitialized when mod_resource_init() is called.
*/
list_for_item_safe(list, _list, &res->cont_chunk_list) {
struct container_chunk *chunk =
container_of(list, struct container_chunk, chunk_list);
Expand Down
Loading