Skip to content

ipc: Fix incorrect dcache invalidate #10301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Oct 17, 2025
+2 −0
Merged

ipc: Fix incorrect dcache invalidate #10301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ipc/ipc-common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ int ipc_process_on_core(uint32_t core, bool blocking)
return -EACCES;
}

#if CONFIG_IPC_MAJOR_3
/* The other core will write there its response */
dcache_invalidate_region((__sparse_force void __sparse_cache *)MAILBOX_HOSTBOX_BASE,
((struct sof_ipc_cmd_hdr *)ipc->comp_data)->size);
#endif

/*
Copy link
Collaborator

@dbaluta dbaluta Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add this under #ifndef IPC4 .. to avoid any issues with IPC3.

Copy link
Collaborator

@lyakh lyakh Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, do any IPC3 users use multicore? Obviously this only affects secondary core execution

Copy link
Member

@abonislawski abonislawski Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Mediatek and AMD uses single core, not sure about NXP

* If the primary core is waiting for secondary cores to complete, it
Expand Down
Loading