Skip to content

ipc4: Fix queue ID extraction #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Oct 22, 2025
Merged

ipc4: Fix queue ID extraction #10298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/audio/copier/copier_generic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ void copier_update_params(struct copier_data *cd, struct comp_dev *dev,
/* update each sink format */
comp_dev_for_each_consumer(dev, sink) {
int j;
j = IPC4_SINK_QUEUE_ID(buf_get_id(sink));
j = IPC4_SRC_QUEUE_ID(buf_get_id(sink));

ipc4_update_buffer_format(sink, &cd->out_fmt[j]);
}
Expand Down
2 changes: 1 addition & 1 deletion src/audio/dai-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ dai_dma_cb(struct dai_data *dd, struct comp_dev *dev, uint32_t bytes,

sink_dev = comp_buffer_get_sink_component(sink);

j = IPC4_SINK_QUEUE_ID(buf_get_id(sink));
j = IPC4_SRC_QUEUE_ID(buf_get_id(sink));

if (j >= IPC4_COPIER_MODULE_OUTPUT_PINS_COUNT) {
comp_err(dev, "Sink queue ID: %d >= max output pin count: %d\n",
Expand Down
8 changes: 4 additions & 4 deletions src/probe/probe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,15 +1102,15 @@ static struct comp_buffer *ipc4_get_buffer(struct ipc_comp_dev *dev, probe_point
switch (probe_point.fields.type) {
case PROBE_TYPE_INPUT:
comp_dev_for_each_producer(dev->cd, buf) {
queue_id = IPC4_SRC_QUEUE_ID(buf_get_id(buf));
queue_id = IPC4_SINK_QUEUE_ID(buf_get_id(buf));

if (queue_id == probe_point.fields.index)
return buf;
}
break;
case PROBE_TYPE_OUTPUT:
comp_dev_for_each_consumer(dev->cd, buf) {
queue_id = IPC4_SINK_QUEUE_ID(buf_get_id(buf));
queue_id = IPC4_SRC_QUEUE_ID(buf_get_id(buf));

if (queue_id == probe_point.fields.index)
return buf;
Expand Down Expand Up @@ -1581,14 +1581,14 @@ static int probe_get_available_points(struct processing_module *mod,

id.fields.type = PROBE_TYPE_INPUT;
comp_dev_for_each_producer(icd->cd, buf) {
id.fields.index = IPC4_SRC_QUEUE_ID(buf_get_id(buf));
id.fields.index = IPC4_SINK_QUEUE_ID(buf_get_id(buf));
if (probe_add_point_info_params(info, id, i, max_size))
return 0;
i++;
}
id.fields.type = PROBE_TYPE_OUTPUT;
comp_dev_for_each_consumer(icd->cd, buf) {
id.fields.index = IPC4_SINK_QUEUE_ID(buf_get_id(buf));
id.fields.index = IPC4_SRC_QUEUE_ID(buf_get_id(buf));
if (probe_add_point_info_params(info, id, i, max_size))
return 0;
i++;
Expand Down
Loading