audio: module_adapter: Set the pipeline pointer during init #10288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
requested review from
RanderWang,
abonislawski,
jxstelter and
pblaszko
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes pipeline pointer initialization by moving it from copier-specific code to the general module adapter initialization. This ensures all modules receive proper pipeline configuration during initialization.
- Moved pipeline pointer and period setup from copier init to module_adapter_new_ext
- Added LL module period configuration to match pipeline period
- Removed redundant pipeline setup code from copier module
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/audio/module_adapter/module_adapter.c | Added centralized pipeline pointer and period initialization for all modules |
| src/audio/copier/copier.c | Removed module-specific pipeline initialization code that is now handled centrally |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ranj063
force-pushed
the
fix/dev_pipeline
branch
3 times, most recently
from
c18790b to
99f57e8
Compare
lgirdwood
approved these changes
Oct 8, 2025
ranj063
force-pushed
the
fix/dev_pipeline
branch
2 times, most recently
from
d12dd3d to
964b4cf
Compare
jsarha
approved these changes
Oct 9, 2025
jsarha
requested changes
Oct 9, 2025
jsarha
approved these changes
Oct 9, 2025
Contributor
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
The real branch is Ok now and I have tested it. For some reason the web interace is not updated accordingly. But I'll approve anyway. Who ever merges this, please make sure the "if (ipc_pipe)" condition makes sense.
ranj063
force-pushed
the
fix/dev_pipeline
branch
2 times, most recently
from
216065e to
debddf4
Compare
Collaborator
Author
|
SOFCI TEST |
Set the pipeline pointer during init for all modules and remove the code from copier init. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/dev_pipeline
branch
from
debddf4 to
3e59d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the pipeline pointer during init for all modules and remove the code from copier init. Also set the pipeline period for all LL modules during init.