Tools: Topology: Enable pre-processing in DMIC function tplgs #10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds DMIC0_ENHANCED_CAPTURE=true to function topologies for PCH DMIC. The function topology is used in a SDW platform if there is a PCH DMIC in use instead of SDW codec connected microphone. The microphone pre-processing adds the multi-microphone beamformer (TDFB) and dynamic range compressor (DRC) components. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg_dmic_func_preprocess
branch
from
327d237 to
69c4c8d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables microphone pre-processing functionality in DMIC function topologies for Intel ACE platforms by adding enhanced capture settings and audio processing parameters.
- Adds
DMIC0_ENHANCED_CAPTURE=trueto enable advanced capture features - Configures TDFB (Time-Domain Fixed Beamformer) parameters for multi-microphone processing
- Sets DRC (Dynamic Range Compressor) parameters for improved audio quality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Enables enhanced capture and processing for PTL platform DMIC topologies |
| tools/topology/topology2/production/tplg-targets-ace2.cmake | Enables enhanced capture and processing for LNL platform DMIC topologies |
| tools/topology/topology2/production/tplg-targets-ace1.cmake | Enables enhanced capture and processing for ARL and MTL platform DMIC topologies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lgirdwood
approved these changes
Oct 6, 2025
kv2019i
approved these changes
Oct 6, 2025
Collaborator
|
@bardliao Ok to proceed with merge? |
bardliao
approved these changes
Oct 8, 2025
Collaborator
Yes, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds DMIC0_ENHANCED_CAPTURE=true to function topologies for PCH DMIC. The function topology is used in a SDW platform if there is a PCH DMIC in use instead of SDW codec connected microphone.
The microphone pre-processing adds the multi-microphone beamformer (TDFB) and dynamic range compressor (DRC) components.