module: tester: Ensure tester module is only built when explicitly selected #10275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lected Prevent the tester module from being built into the image unless explicitly configured, especially when it's configured as a loadable module and llext support is disabled. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
Copilot,
jxstelter and
tmleman
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the tester module build configuration to ensure it's only included when explicitly enabled, preventing unintended inclusion when configured as a loadable module without llext support.
- Changes the CMake condition from checking
CONFIG_COMP_TESTERexistence to verifying it equals "y"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lgirdwood
approved these changes
Oct 1, 2025
tmleman
approved these changes
Oct 1, 2025
abonislawski
approved these changes
Oct 1, 2025
lyakh
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the tester module from being built into the image unless explicitly configured, especially when it's configured as a loadable module and llext support is disabled.