Skip to content

Conversation

@ujfalusi
Copy link
Contributor

@ujfalusi ujfalusi commented Sep 29, 2025

This PR will allow using the Brya with IPC4 if desired.

The PCM list is aligned with the IPC3 list.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063 pls check.

PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\
PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-adl-rt711-4ch.bin,\
HDMI1_ID=4,HDMI2_ID=5,HDMI3_ID=6"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi this shouldnt be in production. Its for testing and should probably go into the development folder. We arent planning on shipping this with our releases, are we?

@ujfalusi ujfalusi force-pushed the peter/pr/tplg2-adl-max98357a-rt5682 branch from 902612a to f5c071a Compare October 1, 2025 06:21
@ujfalusi
Copy link
Contributor Author

ujfalusi commented Oct 1, 2025

Changes since v1:

  • move the Brya IPC4 topology from production to development

Include platform/intel/tgl.conf fro ADL platform

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@ujfalusi ujfalusi force-pushed the peter/pr/tplg2-adl-max98357a-rt5682 branch from f5c071a to 14f5e23 Compare October 1, 2025 10:20
@ujfalusi
Copy link
Contributor Author

ujfalusi commented Oct 1, 2025

Changes since v2:

  • align the PCM list with the one that created by IPC3 on the same machine (if ever we have UCM support for this..)

@ujfalusi
Copy link
Contributor Author

ujfalusi commented Oct 1, 2025

I'm not sure which is better in regards to the PCM lists.
Brya IPC3 (sof-rt5682):

00-00: Speakers (*) :  : playback 1
00-01: Headset (*) :  : playback 1 : capture 1
00-02: HDMI1 (*) :  : playback 1
00-03: HDMI2 (*) :  : playback 1
00-04: HDMI3 (*) :  : playback 1
00-05: HDMI4 (*) :  : playback 1
00-06: EchoRef (*) :  : capture 1
00-99: DMIC (*) :  : capture 1
00-100: DMIC16kHz (*) :  : capture 1

MTL/PTL IPC4 (sof-rt5682):

00-00: Headset (*) :  : playback 1 : capture 1
00-01: Speakers (*) :  : playback 1
00-02: BT Playback (*) :  : playback 1
00-05: HDMI1 (*) :  : playback 1
00-06: HDMI2 (*) :  : playback 1
00-07: HDMI3 (*) :  : playback 1
00-31: Deepbuffer Jack Out (*) :  : playback 1
00-35: Deepbuffer Amps (*) :  : playback 1
00-99: DMIC Raw (*) :  : capture 1

Brya has no BT offload, HS and Speaker PCMs are swapped, HDMI PCM starts at different number...

@ujfalusi ujfalusi force-pushed the peter/pr/tplg2-adl-max98357a-rt5682 branch from 14f5e23 to dd97681 Compare October 1, 2025 11:57
@ujfalusi
Copy link
Contributor Author

ujfalusi commented Oct 1, 2025

Changes since v3:

  • after consulting with @singalsu, revert back to align with IPC4 topologies.

Enable building topology for adl-max98357a-rt5682 which is used by Google
Brya devices.
The PCM list is aligned with other max98357a-rt5682 IPC4 devices and _not_
with the IPC3 sound card.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@kv2019i kv2019i merged commit de8883c into thesofproject:main Oct 1, 2025
31 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants