app: boards: share (yet more) common audio build options for Intel ADSPs #10264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIG_MM_DRV is set based on hardware properties in the Zephyr soc defconfig file, so no need to set this in each board file. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Remove a few leftover unnecessary statements to set COMP_CHAIN_DMA=y. This is already set in the board defconfig for the Intel DSPs, so no need to set this in the board file. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move COMP_KPB to the shared defconfig file. This has not been enabled for cavs25 boards, but no reason why not, so enable it for all. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move COMP_UP_DOWN_MIXER to the shared defconfig file. This has not been enabled for cavs25 boards, but no reason why not, so enable it for all. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move COMP_VOLUME_WINDOWS_FADE to the shared defconfig file. This has not been enabled for cavs25 boards, but no reason why not, so enable it for all. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes common audio build options for Intel ADSP boards by moving duplicated configuration options from individual board configuration files to a shared Kconfig.defconfig file. This follows up on previous work to consolidate common build settings.
- Removes duplicate CONFIG_MM_DRV, CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE options from individual board files
- Adds these common configurations to the shared intel_adsp/Kconfig.defconfig file with default values
- Streamlines maintenance by reducing configuration duplication across Intel ADSP board variants
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/boards/intel_adsp/Kconfig.defconfig | Adds shared default configurations for MM_DRV, COMP_KPB, COMP_UP_DOWN_MIXER, and COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_cavs25_tgph.conf | Removes CONFIG_MM_DRV (now inherited from shared defaults) |
| app/boards/intel_adsp_cavs25.conf | Removes CONFIG_MM_DRV (now inherited from shared defaults) |
| app/boards/intel_adsp_ace40_nvls.conf | Removes CONFIG_MM_DRV, CONFIG_COMP_CHAIN_DMA, CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_ace40_nvl.conf | Removes CONFIG_MM_DRV, CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_ace30_wcl_sim.conf | Removes CONFIG_COMP_VOLUME_WINDOWS_FADE and CONFIG_COMP_UP_DOWN_MIXER |
| app/boards/intel_adsp_ace30_wcl.conf | Removes CONFIG_MM_DRV, CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_ace30_ptl_sim.conf | Removes CONFIG_COMP_VOLUME_WINDOWS_FADE and CONFIG_COMP_UP_DOWN_MIXER |
| app/boards/intel_adsp_ace30_ptl.conf | Removes CONFIG_MM_DRV, CONFIG_COMP_CHAIN_DMA, CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_ace20_lnl.conf | Removes CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
| app/boards/intel_adsp_ace15_mtpm.conf | Removes CONFIG_COMP_KPB, CONFIG_COMP_UP_DOWN_MIXER, and CONFIG_COMP_VOLUME_WINDOWS_FADE |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lyakh
approved these changes
Sep 29, 2025
lgirdwood
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10236 .
This is for now the last in the series.