boards: ace40: enable cold store DRAM execution #10261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR enables cold store DRAM execution for the Intel ADSP ACE 4.0 NVL board by adding the CONFIG_COLD_STORE_EXECUTE_DRAM configuration option.
- Adds CONFIG_COLD_STORE_EXECUTE_DRAM=y to the board configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Member
Author
|
No worries, I can rebase it after 10236 |
abonislawski
force-pushed
the
nvl_cold_store_execution
branch
from
6e3f80c to
d29bdd7
Compare
kv2019i
approved these changes
Sep 25, 2025
lyakh
approved these changes
Sep 26, 2025
Collaborator
|
@abonislawski This had QB fails so I went with #10236 first. |
tmleman
approved these changes
Sep 26, 2025
lgirdwood
approved these changes
Sep 30, 2025
Member
|
@abonislawski some conflicts. |
Collaborator
|
@abonislawski The common board file changes are now done for Intel DSPs, so safe to rebase now. |
Required changes to enable CONFIG_COLD_STORE_EXECUTE_DRAM for ACE 4.0 nvl.toml.h -> add COLD module.entry novalake memory.h -> add __cold define support Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Enable CONFIG_COLD_STORE_EXECUTE_DRAM for ACE 4.0 Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
nvl_cold_store_execution
branch
from
d29bdd7 to
7f3ee6f
Compare
Member
Author
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CONFIG_COLD_STORE_EXECUTE_DRAM for ACE 4.0