Skip to content

Conversation

@abonislawski
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings September 25, 2025 06:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables LLEXT (Loadable Link Extensions) and openmodules library support for the ACE40 board platform. The changes configure the necessary build and runtime settings to support dynamically loadable modules on Intel ADSP ACE40 hardware.

Key changes:

  • Added platform configuration mapping for ACE40 to use NVL platform settings
  • Enabled LLEXT subsystem with experimental and writable storage support
  • Configured library management with specific base address and modular defaults

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/rimage/config/platform.toml Maps ACE40 SoC configuration to NVL platform settings
app/boards/intel_adsp_ace40_nvl.conf Enables LLEXT and library management configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 26, 2025

@abonislawski This had QB fails so I went with #10236 first.

@lgirdwood
Copy link
Member

@abonislawski conflicts

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 30, 2025

@abonislawski The common board file changes are now done for Intel DSPs, so safe to rebase now.

This is required to build single NVL loadable module

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
When this header is then
preprocessed with that macro defined, all module TOML files will be
included.

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@abonislawski
Copy link
Member Author

Rebased and added one more required change in nvl.toml.h (FORCE_ALL_MODULES)

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski can you check CI thanks !

Copy link
Collaborator

@softwarecki softwarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rather looks like a problem with the build platform:
ModuleNotFoundError: No module named 'jsonschema'

@lgirdwood
Copy link
Member

This rather looks like a problem with the build platform: ModuleNotFoundError: No module named 'jsonschema'

Ok, I think this is known - Btw what about Internal CI ?

@softwarecki
Copy link
Collaborator

@abonislawski look at internal CI pls

@abonislawski
Copy link
Member Author

3 repeatable fails, no quick fix for that

@lrudyX
Copy link

lrudyX commented Oct 7, 2025

3 repeatable fails, no quick fix for that

Internal CI passes with other PRs

added volume_hifi5.c and volume_hifi5_with_peakvol.c files
to the llext build configuration for the volume module
to provide full support for the HiFi5 platform.

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@abonislawski
Copy link
Member Author

One more fix added for the volume llext CMake. The HiFi5 files were missing from the build.

added src_hifi5.c file
to the llext build configuration for the volume module
to provide full support for the HiFi5 platform.

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
added asrc_farrow_hifi5.c file
to the llext build configuration for the volume module
to provide full support for the HiFi5 platform.

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Enable LLEXT and openmodule lib build for ACE 4.0

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@abonislawski
Copy link
Member Author

And the same fixed for SRC and ASRC, lets wait for CI now

@abonislawski
Copy link
Member Author

Ok, good to merge now

@kv2019i kv2019i merged commit 2e1dcfc into thesofproject:main Oct 16, 2025
40 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants