-
Notifications
You must be signed in to change notification settings - Fork 349
boards: ace40: enable LLEXT and openmodules lib #10260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables LLEXT (Loadable Link Extensions) and openmodules library support for the ACE40 board platform. The changes configure the necessary build and runtime settings to support dynamically loadable modules on Intel ADSP ACE40 hardware.
Key changes:
- Added platform configuration mapping for ACE40 to use NVL platform settings
- Enabled LLEXT subsystem with experimental and writable storage support
- Configured library management with specific base address and modular defaults
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rimage/config/platform.toml | Maps ACE40 SoC configuration to NVL platform settings |
| app/boards/intel_adsp_ace40_nvl.conf | Enables LLEXT and library management configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@abonislawski This had QB fails so I went with #10236 first. |
|
@abonislawski conflicts |
|
@abonislawski The common board file changes are now done for Intel DSPs, so safe to rebase now. |
This is required to build single NVL loadable module Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
When this header is then preprocessed with that macro defined, all module TOML files will be included. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
842f437 to
f33cf03
Compare
|
Rebased and added one more required change in nvl.toml.h (FORCE_ALL_MODULES) |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abonislawski can you check CI thanks !
softwarecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rather looks like a problem with the build platform:
ModuleNotFoundError: No module named 'jsonschema'
Ok, I think this is known - Btw what about Internal CI ? |
|
@abonislawski look at internal CI pls |
|
3 repeatable fails, no quick fix for that |
Internal CI passes with other PRs |
added volume_hifi5.c and volume_hifi5_with_peakvol.c files to the llext build configuration for the volume module to provide full support for the HiFi5 platform. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
f33cf03 to
680e94c
Compare
|
One more fix added for the volume llext CMake. The HiFi5 files were missing from the build. |
added src_hifi5.c file to the llext build configuration for the volume module to provide full support for the HiFi5 platform. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
added asrc_farrow_hifi5.c file to the llext build configuration for the volume module to provide full support for the HiFi5 platform. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Enable LLEXT and openmodule lib build for ACE 4.0 Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
680e94c to
95b2301
Compare
|
And the same fixed for SRC and ASRC, lets wait for CI now |
|
Ok, good to merge now |
No description provided.