Add missing function topology #10231
Conversation
Fix the platfrom name of PTL function topologies. Fixes: 77d5e99 ("topology2: add topologies for each sdca functions") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add different DMIC BE ID function topologies for ACE3 platforms. Also, the HDMI BE id could be 2 or 3 if there is no PCH DMIC is used. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
Fix platform name inconsistencies in PTL DMIC function topologies and adds missing function topology variants for different ID configurations.
- Corrects platform name from "mtl" to "ptl" in PTL DMIC function topologies
- Adds missing HDMI PCM5 topology variants for ID2 and ID3 configurations
- Adds missing PTL DMIC topology variants for ID2, ID3, and ID4 configurations in both 2-channel and 4-channel versions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-sdca-generic.cmake | Adds missing HDMI PCM5 topology variants for ID2 and ID3 |
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Fixes platform name from "mtl" to "ptl" and adds missing PTL DMIC topology variants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
simontrimmer
left a comment
simontrimmer
left a comment
There was a problem hiding this comment.
Verified the sof-hdmi change on an 10280d33 with mic mute enabled, which loaded sof-hdmi-pcm5-id3.tplg
Mic changes look good, good idea extending the ID ranges
| HDMI_IN_1_ID=0,HDMI_IN_2_ID=1" | ||
|
|
||
| # Split topologies | ||
| "cavs-sdw\;sof-ptl-dmic-2ch-id2\;PLATFORM=ptl,SDW_JACK=false,NUM_HDMIS=0,NUM_DMICS=2,\ |
There was a problem hiding this comment.
@bardliao how is this idX suffix identified/used in the kernel? Just for my education
There was a problem hiding this comment.
@ranj063 The idX suffix is added by sof_sdw_get_tplg_files() to identify the BE id.
https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/intel/common/sof-function-topology-lib.c#L110
5 participants
Fix PTL DMIC function topologies platform name and add some missing function topologies.