Skip to content

buffers: Fix set_underrun/set_overrun calls #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbaluta wants to merge 1 commit into from
Closed

buffers: Fix set_underrun/set_overrun calls #10228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/audio/buffers/comp_buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,6 @@ static struct comp_buffer *buffer_alloc_struct(void *stream_addr, size_t size,
audio_stream_set_addr(&buffer->stream, stream_addr);
buffer_init_stream(buffer, size);

audio_stream_set_underrun(&buffer->stream, !!(flags & SOF_BUF_UNDERRUN_PERMITTED));
audio_stream_set_overrun(&buffer->stream, !!(flags & SOF_BUF_OVERRUN_PERMITTED));

comp_buffer_reset_source_list(buffer);
comp_buffer_reset_sink_list(buffer);

Expand Down
5 changes: 5 additions & 0 deletions src/ipc/ipc-helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ __cold struct comp_buffer *buffer_new(const struct sof_ipc_buffer *desc, bool is
buffer->stream.runtime_stream_params.pipeline_id = desc->comp.pipeline_id;
buffer->core = desc->comp.core;

audio_stream_set_underrun(&buffer->stream,
!!(desc->flags & SOF_BUF_UNDERRUN_PERMITTED));
audio_stream_set_overrun(&buffer->stream,
!!(desc->flags & SOF_BUF_OVERRUN_PERMITTED));
Copy link
Collaborator

@lyakh lyakh Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem enough to me. Line 81 above still calls buffer_alloc() with flags derived from desc->flags which now isn't correct. I think #10227 is a better fix.


memcpy_s(&buffer->tctx, sizeof(struct tr_ctx),
&buffer_tr, sizeof(struct tr_ctx));
}
Expand Down
Loading