Skip to content

Test: Cmocka: Fixes for math library tests memory leaks #10224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
singalsu wants to merge 1 commit into from
Closed

Test: Cmocka: Fixes for math library tests memory leaks #10224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/cmocka/src/math/auditory/auditory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ static void filterbank_16_test(const int16_t *fft_real, const int16_t *fft_imag,
fclose(fh);
#endif

free(fb.data);
free(mel_log);
free(fft_out);
free(fft_buf);
assert_true(error_rms < MEL_FB16_MAX_ERROR_RMS);
assert_true(delta_max < MEL_FB16_MAX_ERROR_ABS);
return;
Expand Down Expand Up @@ -229,6 +233,10 @@ static void filterbank_32_test(const int32_t *fft_real, const int32_t *fft_imag,
fclose(fh);
#endif

free(fb.data);
free(mel_log);
free(fft_out);
free(fft_buf);
assert_true(error_rms < MEL_FB32_MAX_ERROR_RMS);
assert_true(delta_max < MEL_FB32_MAX_ERROR_ABS);
return;
Expand Down
1 change: 1 addition & 0 deletions test/cmocka/src/math/dct/dct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ static void dct_matrix_16_test(const int16_t *ref, int num_in, int num_out,
printf("Max absolute error = %5.2f (max %5.2f), error RMS = %5.2f (max %5.2f)\n",
delta_max, MATRIX_MULT_16_MAX_ERROR_ABS, error_rms, MATRIX_MULT_16_MAX_ERROR_RMS);

free(dct.matrix);
assert_true(error_rms < MATRIX_MULT_16_MAX_ERROR_RMS);
assert_true(delta_max < MATRIX_MULT_16_MAX_ERROR_ABS);
}
Expand Down
30 changes: 30 additions & 0 deletions test/cmocka/src/math/fft/fft.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ static void test_math_fft_256(void **state)
noise += integrate_power_32(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_256, 0);
}

Expand Down Expand Up @@ -341,6 +344,9 @@ static void test_math_fft_512(void **state)
noise += integrate_power_32(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_512, 0);
}

Expand Down Expand Up @@ -383,6 +389,9 @@ static void test_math_fft_1024(void **state)
noise += integrate_power_32(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_1024, 0);
}

Expand Down Expand Up @@ -424,6 +433,10 @@ static void test_math_fft_1024_ifft(void **state)

db = 10 * log10((float)signal / noise);
printf("%s: SNR: %6.2f dB\n", __func__, db);

buffer_free(sink);
buffer_free(intm);
buffer_free(source);
assert_int_equal(db < FFT_DB_TH, 0);
}

Expand Down Expand Up @@ -465,6 +478,10 @@ static void test_math_fft_512_2ch(void **state)
i = (SINE_HZ * fft_size) / 48000;
printf("%s: peak for channel 1 at point %d\n", __func__, r);

buffer_free(sink2);
buffer_free(sink1);
buffer_free(source);

/* the peak should be in range i +/-1 */
assert_in_range(r, i - 1, i + 1);
}
Expand Down Expand Up @@ -659,6 +676,9 @@ static void test_math_fft_256_16(void **state)
noise += integrate_power_16(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_256_16, 0);
}

Expand Down Expand Up @@ -701,6 +721,9 @@ static void test_math_fft_512_16(void **state)
noise += integrate_power_16(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_512_16, 0);
}

Expand Down Expand Up @@ -743,6 +766,9 @@ static void test_math_fft_1024_16(void **state)
noise += integrate_power_16(out, i + 2, fft_size / 2 - 1);
snr = 10 * log10(signal / noise);
printf("%s: SNR %5.2f dB\n", __func__, snr);

buffer_free(sink);
buffer_free(source);
assert_int_equal(snr < MIN_SNR_1024_16, 0);
}

Expand Down Expand Up @@ -783,6 +809,10 @@ static void test_math_fft_1024_ifft_16(void **state)

db = 10 * log10((float)signal / noise);
printf("%s: SNR: %6.2f dB\n", __func__, db);

buffer_free(sink);
buffer_free(intm);
buffer_free(source);
assert_int_equal(db < FFT_DB_TH_16, 0);
}

Expand Down
3 changes: 3 additions & 0 deletions test/cmocka/src/math/matrix/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ static void matrix_mult_16_test(const int16_t *a_ref, const int16_t *b_ref, cons
printf("Max absolute error = %5.2f (max %5.2f), error RMS = %5.2f (max %5.2f)\n",
delta_max, MATRIX_MULT_16_MAX_ERROR_ABS, error_rms, MATRIX_MULT_16_MAX_ERROR_RMS);

free(c_matrix);
free(b_matrix);
free(a_matrix);
assert_true(error_rms < MATRIX_MULT_16_MAX_ERROR_RMS);
assert_true(delta_max < MATRIX_MULT_16_MAX_ERROR_ABS);
}
Expand Down
Loading