Skip to content

Conversation

@naveen-manohar
Copy link
Contributor

topology2: ace3: Add enhanced audio features to ptl-rt721-4ch target
Add support to extend ptl-rt721-4ch conf with audio processing:

  • Enhanced DMIC0 capture with TDFB & DRC processing
  • Add Bluetooth PCM support (ID 20, device ID 10)
  • Enable deep buffer speaker processing with 10ms DMA buffer
  • Configure TDFB line4_pass and DRC dmic_default parameters

Add support to extend ptl-rt721-4ch conf with audio processing:
- Enhanced DMIC0 capture with TDFB & DRC processing
- Add Bluetooth PCM support (ID 20, device ID 10)
- Enable deep buffer speaker processing with 10ms DMA buffer
- Configure TDFB line4_pass and DRC dmic_default parameters

Signed-off-by: Naveen Manohar <naveen.m@intel.com>
Copilot AI review requested due to automatic review settings August 29, 2025 18:46
@naveen-manohar naveen-manohar changed the base branch from main to ptl-006-drop-stable August 29, 2025 18:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

kv2019i
kv2019i previously requested changes Sep 2, 2025
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we already have one BT-enabled config in main, but before this gets into more topologies, let's try to get a more future-proof model how to support Bluetooth in SDW before we proceed further. @bardliao @ujfalusi can you check, this needs alignment with kernel.

PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt721-4ch.bin,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\
BT_PCM_ID=20,BT_ID=10,BT_PCM_NAME=Bluetooth,ADD_BT=true,\
DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we have a problem with the BT enabling, see thesofproject/linux#5518

This topology is pretty common and could match non-chromebook devices but the BT quirk is only set for chromebook boards in Linux kernel, so this could break devices upstream.

@bardliao ok if we branch out and put any new SDW topologies with BT with a separate suffix. Chromebooks use a udev rule to pick the topology file anywas, so this should be managable, right @naveen-manohar ?

We have sof-ptl-rt712-l3-rt1320-l3-4ch already with BT support, but I think that's the only one so far.

So sof-ptl-rt721-4ch-bt-ssp2.tplg , with ther identical contents but adds the BT PCM. Then non-chromebook devices can load the base variant, and chromebooks can use the one with BT PCM added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, now i noticed this connect.
As this is supposed to be verified on both PTL & WCL, have created a new PR requesting merge to main, PR:pull/10203 was targetting only for ptl-006.

@kv2019i have removed BT with #10221
Kindly help review that.

Add deep buffer PCM35 on amps for ptl-rt721-4ch tplg.

Signed-off-by: Naveen Manohar <naveen.m@intel.com>
@naveen-manohar naveen-manohar changed the base branch from ptl-006-drop-stable to main September 8, 2025 09:40
@naveen-manohar naveen-manohar changed the base branch from main to ptl-006-drop-stable September 8, 2025 09:40
@kv2019i kv2019i dismissed their stale review September 11, 2025 14:45

PR merged to main in modified form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants