-
Notifications
You must be signed in to change notification settings - Fork 349
topology2: ace3: Add enhanced audio features to ptl-rt721-4ch target #10203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ptl-006-drop-stable
Are you sure you want to change the base?
topology2: ace3: Add enhanced audio features to ptl-rt721-4ch target #10203
Conversation
Add support to extend ptl-rt721-4ch conf with audio processing: - Enhanced DMIC0 capture with TDFB & DRC processing - Add Bluetooth PCM support (ID 20, device ID 10) - Enable deep buffer speaker processing with 10ms DMA buffer - Configure TDFB line4_pass and DRC dmic_default parameters Signed-off-by: Naveen Manohar <naveen.m@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt721-4ch.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| BT_PCM_ID=20,BT_ID=10,BT_PCM_NAME=Bluetooth,ADD_BT=true,\ | ||
| DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we have a problem with the BT enabling, see thesofproject/linux#5518
This topology is pretty common and could match non-chromebook devices but the BT quirk is only set for chromebook boards in Linux kernel, so this could break devices upstream.
@bardliao ok if we branch out and put any new SDW topologies with BT with a separate suffix. Chromebooks use a udev rule to pick the topology file anywas, so this should be managable, right @naveen-manohar ?
We have sof-ptl-rt712-l3-rt1320-l3-4ch already with BT support, but I think that's the only one so far.
So sof-ptl-rt721-4ch-bt-ssp2.tplg , with ther identical contents but adds the BT PCM. Then non-chromebook devices can load the base variant, and chromebooks can use the one with BT PCM added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add deep buffer PCM35 on amps for ptl-rt721-4ch tplg. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
topology2: ace3: Add enhanced audio features to ptl-rt721-4ch target
Add support to extend ptl-rt721-4ch conf with audio processing: