-
Notifications
You must be signed in to change notification settings - Fork 349
nvl: Fix CI failure #10197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
nvl: Fix CI failure #10197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toolchain for ACE4 is not yet available in Zephyr. Move (temporarily) nvl and nvl-s platforms to extra_platform_configs to avoid CI build with missing Zephyr toolchain. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
lgirdwood
approved these changes
Aug 27, 2025
tmleman
approved these changes
Aug 27, 2025
Member
|
@lrudyX not expecting this to fail as it fixes a GitHub action. |
Contributor
Author
Added second commit which enables tester module on NVL/NVL-S required by recently added NVL/NVL-S CI. |
lgirdwood
approved these changes
Aug 27, 2025
tester.toml should be included by the platform's *.toml.h file in order for the tester module to be functional as a builtin module. Before this fix, the tester module only worked on MTL as a builtin and as an LLEXT module on LNL, PTL, WCL. And not functional at all on NVL. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Enable tester module used by CI tests. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
1b66ae1 to
ed68f76
Compare
kv2019i
approved these changes
Aug 27, 2025
Collaborator
|
Quickbuild failing, otherwise good to go. |
softwarecki
approved these changes
Aug 28, 2025
Contributor
Author
Lukasz temporary removed the failing CI test. Now CI passes. |
marcinszkudlinski
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolchain for ACE4 is not yet available in Zephyr. Move (temporarily) nvl and nvl-s platforms to extra_platform_configs to avoid CI build with missing Zephyr toolchain.
Enable tester module used by CI tests. This is to fix recently added NVL/NVL-S CI.