intel-adsp: (cosmetic) re-group Kconfig options #10192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This is a cosmetic reorganization PR that groups Memory Management (MM) driver configuration options together in Intel ADSP board configuration files. The change improves configuration file organization without affecting functionality.
- Move
CONFIG_MM_DRV_INTEL_VIRTUAL_REGION_COUNT=2from various sections to group it with other MM driver options - Maintain consistent ordering across all Intel ADSP board configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| intel_adsp_ace30_wcl.conf | Moved MM virtual region count config to group with other MM driver options |
| intel_adsp_ace30_ptl.conf | Moved MM virtual region count config to group with other MM driver options |
| intel_adsp_ace20_lnl.conf | Moved MM virtual region count config to group with other MM driver options |
| intel_adsp_ace15_mtpm.conf | Moved MM virtual region count config to group with other MM driver options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kv2019i
requested changes
Aug 25, 2025
Group MM driver options together in Intel ADSP configurations. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
approved these changes
Aug 26, 2025
kv2019i
approved these changes
Aug 26, 2025
Member
|
@lrudyX this is a cosmetic cleanup, so not expecting a failure. Good to merge ? |
tmleman
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group MM driver options together in Intel ADSP configurations.