Skip to content

Conversation

@bardliao
Copy link
Collaborator

Add sof-arl-rt711-l0-rt1316-l3 topology and the with PCH DMIC variations support. They are copied from the sof-mtl-rt711-l0-rt1316-l3 series.

Link: thesofproject/linux#5474

Add sof-arl-rt711-l0-rt1316-l3 topology and the with PCH DMIC
variations support. They are copied from the sof-mtl-rt711-l0-rt1316-l3
series.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds ARL (Arrow Lake) topology configurations for rt711-l0-rt1316-l3 audio setups, extending support from the existing MTL (Meteor Lake) platform. This includes base topology and variations with different PCH DMIC channel configurations.

  • Adds three new ARL topology targets: base, 4-channel DMIC, and 2-channel DMIC variants
  • Configures SoundWire amplifier and DMIC parameters for each variant
  • Sets up HDMI IDs and audio processing parameters for enhanced capture modes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +151 to +162
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
HDMI1_ID=4,HDMI2_ID=5,HDMI3_ID=6"

"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-4ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\
PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-arl-rt711-l0-rt1316-l3-4ch.bin,\
HDMI1_ID=6,HDMI2_ID=7,HDMI3_ID=8,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default"

"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PLATFORM parameter is set to 'mtl' for ARL topology. This should be 'arl' to match the intended Arrow Lake platform instead of Meteor Lake.

Suggested change
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
HDMI1_ID=4,HDMI2_ID=5,HDMI3_ID=6"
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-4ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\
PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-arl-rt711-l0-rt1316-l3-4ch.bin,\
HDMI1_ID=6,HDMI2_ID=7,HDMI3_ID=8,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default"
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3\;PLATFORM=arl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
HDMI1_ID=4,HDMI2_ID=5,HDMI3_ID=6"
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-4ch\;PLATFORM=arl,NUM_SDW_AMP_LINKS=1,\
SDW_SPK_STREAM=SDW3-Playback,SDW_SPK_IN_STREAM=SDW3-Capture,\
NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\
PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-arl-rt711-l0-rt1316-l3-4ch.bin,\
HDMI1_ID=6,HDMI2_ID=7,HDMI3_ID=8,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default"
"cavs-sdw\;sof-arl-rt711-l0-rt1316-l3-2ch\;PLATFORM=arl,NUM_SDW_AMP_LINKS=1,\

Copilot uses AI. Check for mistakes.
@lgirdwood lgirdwood merged commit fc73c6e into thesofproject:main Aug 26, 2025
35 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants