Skip to content

2 cosmetic and minor improvement patches #10187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 2 commits into from
Sep 11, 2025
Merged

2 cosmetic and minor improvement patches #10187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca8ff1
module-adapter: move a calculation outside a loop
lyakh Aug 22, 2025
aba91e5
ipc: (cosmetic) remove a redundant statement
lyakh Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/audio/module_adapter/module_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,9 @@ int module_adapter_prepare(struct comp_dev *dev)
mod->output_buffer_size = buff_size;

/* allocate memory for input buffer data */
list_for_item(blist, &dev->bsource_list) {
size_t size = MAX(mod->deep_buff_bytes, mod->period_bytes);
size_t size = MAX(mod->deep_buff_bytes, mod->period_bytes);

list_for_item(blist, &dev->bsource_list) {
Copy link
Collaborator

@kv2019i kv2019i Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, compiler should optimize that out? This does bring "size" to the wider scope, so not sure if this is better. Not blocking...

Copy link
Collaborator Author

@lyakh lyakh Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i I'm not sure the compiler is able to deduce that mod->deep_buff_bytes and mod->period_bytes don't change while the loop is executed. So I wouldn't rely on that

mod->input_buffers[i].data = rballoc(memory_flags, size);
if (!mod->input_buffers[i].data) {
comp_err(mod->dev, "Failed to alloc input buffer data");
Expand Down
1 change: 0 additions & 1 deletion src/ipc/ipc-helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ int comp_verify_params(struct comp_dev *dev, uint32_t flag,
* there's just nothing to update
*/
comp_dbg(dev, "no connected buffers");
return 0;
} else {
/* for other components we iterate over all downstream buffers
* (for playback) or upstream buffers (for capture).
Expand Down
Loading