-
Notifications
You must be signed in to change notification settings - Fork 349
app: boards: intel_adsp_ace30_ptl/wcl: disable winconsole logs #10180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: boards: intel_adsp_ace30_ptl/wcl: disable winconsole logs #10180
Conversation
Disable the winconsole logging method. The winconsole logging method uses the same memory window as CONFIG_SOF_TELEMETRY and must not be enabled at the same time. Even without the conflict, we don't need to have multiple logging methods enabled by default. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables duplicate logging backends on Intel ADSP ACE30 PTL and WCL boards to align their configurations with other Intel boards. The changes remove redundant logging mechanisms that were previously enabled alongside the primary MTRACE logging backend.
- Disables the default ADSP logging backend while keeping MTRACE enabled
- Disables the WINSTREAM console logging feature
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/boards/intel_adsp_ace30_ptl.conf | Adds configuration to disable ADSP backend and WINSTREAM console logging |
| app/boards/intel_adsp_ace30_wcl.conf | Adds configuration to disable ADSP backend and WINSTREAM console logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| CONFIG_LOG_MODE_DEFERRED=y | ||
| CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y | ||
| CONFIG_LOG_TIMESTAMP_64BIT=y | ||
| CONFIG_WINSTREAM_CONSOLE=n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are they enabled by default? Maybe the default should be changed - that's what we're relying on not to have to set all unneeded Kconfig options to "n" explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh That should be also done, but currently Zephyr CI relies on these, so somebody who knows where to change the CI tests needs to do the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i just need to remove https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/Kconfig.defconfig#L39-L42 . I'm not even sure we need CONFIG_CONSOLE. Just have tried disabling both of them and removing https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/Kconfig.defconfig#L36-L37 and https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/ace/Kconfig.defconfig.series#L53-L58 and the logging is still working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i how about zephyrproject-rtos/zephyr#94931 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack @lyakh . Commented on the Zephyr item. I think this is good for SOF, but I was referring to Zephyr CI. But if ok to them (and they can enable winconsole logs in their test builds), then that should work.
|
Hmm, went through the Intel internal CI fail log, but seems like a CI/tooling issue. I see error on "return get_fw()" on multiple platforms. Let me refresh the series and try again. |
Disable the winconsole logging method. The winconsole logging method uses the same memory window as CONFIG_SOF_TELEMETRY and must not be enabled at the same time. Even without the conflict, we don't need to have multiple logging methods enabled by default. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
fd69efe to
d8aa285
Compare
We have duplicate logging enabled, align the configs with other Intel boards.