Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Aug 21, 2025

We have duplicate logging enabled, align the configs with other Intel boards.

Disable the winconsole logging method. The winconsole logging
method uses the same memory window as CONFIG_SOF_TELEMETRY and must
not be enabled at the same time. Even without the conflict, we don't
need to have multiple logging methods enabled by default.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Copilot AI review requested due to automatic review settings August 21, 2025 11:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables duplicate logging backends on Intel ADSP ACE30 PTL and WCL boards to align their configurations with other Intel boards. The changes remove redundant logging mechanisms that were previously enabled alongside the primary MTRACE logging backend.

  • Disables the default ADSP logging backend while keeping MTRACE enabled
  • Disables the WINSTREAM console logging feature

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/boards/intel_adsp_ace30_ptl.conf Adds configuration to disable ADSP backend and WINSTREAM console logging
app/boards/intel_adsp_ace30_wcl.conf Adds configuration to disable ADSP backend and WINSTREAM console logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

CONFIG_LOG_MODE_DEFERRED=y
CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y
CONFIG_LOG_TIMESTAMP_64BIT=y
CONFIG_WINSTREAM_CONSOLE=n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are they enabled by default? Maybe the default should be changed - that's what we're relying on not to have to set all unneeded Kconfig options to "n" explicitly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh That should be also done, but currently Zephyr CI relies on these, so somebody who knows where to change the CI tests needs to do the change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack @lyakh . Commented on the Zephyr item. I think this is good for SOF, but I was referring to Zephyr CI. But if ok to them (and they can enable winconsole logs in their test builds), then that should work.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Aug 25, 2025

Hmm, went through the Intel internal CI fail log, but seems like a CI/tooling issue. I see error on "return get_fw()" on multiple platforms. Let me refresh the series and try again.

Disable the winconsole logging method. The winconsole logging
method uses the same memory window as CONFIG_SOF_TELEMETRY and must
not be enabled at the same time. Even without the conflict, we don't
need to have multiple logging methods enabled by default.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202508-disable-winconsole-for-ace3 branch from fd69efe to d8aa285 Compare August 25, 2025 16:02
@kv2019i kv2019i merged commit 5c9f7b7 into thesofproject:main Aug 25, 2025
36 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants