Audio: Template Comp: Fix build for CONFIG_FORMAT_S24LE only #10179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build of template-generic.c would fail if only S24_LE format would be enabled without S32_LE. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Fixes a build error in the template component when only S24_LE format is enabled without S32_LE format by correcting a copy-paste error in the preprocessor conditional.
- Corrected duplicate CONFIG_FORMAT_S32LE condition to properly include CONFIG_FORMAT_S24LE
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #endif /* CONFIG_FORMAT_S16LE */ | ||
|
|
||
| #if CONFIG_FORMAT_S32LE || CONFIG_FORMAT_S32LE | ||
| #if CONFIG_FORMAT_S32LE || CONFIG_FORMAT_S24LE |
There was a problem hiding this comment.
The original line had CONFIG_FORMAT_S32LE duplicated instead of CONFIG_FORMAT_S24LE. This fix correctly enables the S32/S24 processing function when either S32_LE or S24_LE formats are configured, resolving the build failure when only S24_LE is enabled.
lyakh
approved these changes
Aug 21, 2025
kv2019i
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of template-generic.c would fail if only S24_LE format would be enabled without S32_LE.