zephyr: alloc: calculate L3 heap size based on actual IMR size #10173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonislawski
requested review from
dabekjakub,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Updates L3 heap management to dynamically calculate heap size from hardware IMR registers instead of using hardcoded values, and adds conditional initialization based on IMR availability.
- Replaces hardcoded IMR_L3_HEAP_SIZE with dynamic calculation using ace_imr_get_mem_size()
- Adds conditional L3 heap initialization that only occurs when IMR is actually used
- Includes MMU memory mapping for the L3 heap when CONFIG_MMU is enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| zephyr/lib/alloc.c | Updates L3 heap size calculation and adds conditional initialization with MMU support |
| west.yml | Updates Zephyr revision to pull request branch |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
abonislawski
force-pushed
the
imr_runtime_size
branch
2 times, most recently
from
997bf96 to
4929754
Compare
lyakh
reviewed
Aug 20, 2025
af974c307477 soc: intel_adsp: ace: add IMR info registers 35a1e62035fd soc: intel_adsp: ace40: extend hwreg1 MMU mapping Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Updates the L3 heap management to dynamically calculate heap size based on the actual IMR size reported by hardware registers instead of using hardcoded values. Only initializes the L3 heap when the IMR is actually available and being used, as determined by the ace_imr_used() function, improving robustness by preventing the initialization of unavailable memory regions. Adds proper memory mapping when MMU is enabled, which maps the physical L3 heap memory to a virtual address with appropriate permissions (read/write with write-back caching). MMU mapping is required because it is no longer a fixed region with fixed mapping in Zephyr. This change makes the L3 heap allocation more flexible and adaptable to different hardware configurations. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
imr_runtime_size
branch
2 times, most recently
from
402d5ae to
76252e7
Compare
Member
Author
|
Rebase + west commit update (Zephyr PR is merged) |
lgirdwood
approved these changes
Nov 25, 2025
lyakh
reviewed
Nov 26, 2025
| void *cached_ptr = sys_cache_cached_ptr_get(l3_heap_start); | ||
| uintptr_t va = POINTER_TO_UINT(cached_ptr); | ||
|
|
||
| arch_mem_map(l3_heap_start, va, l3_heap_size, K_MEM_PERM_RW | K_MEM_CACHE_WB); |
Collaborator
There was a problem hiding this comment.
btw, why not sys_mm_drv_map_region()?
Member
Author
There was a problem hiding this comment.
They are not equivalent, just like the lib/llext manager - we are using both of them. In short, the MM TLB driver is for SRAM memory. I assume in the future we will get some nicer API instead of arch_mem_map.
1 task
Member
Author
|
sof-ci/jenkins/pr-build failing on TGL because this zephyr version is no longer compatible with TGL |
Draft
tmleman
approved these changes
Nov 26, 2025
serhiy-katsyuba-intel
approved these changes
Nov 26, 2025
Member
Author
|
SOFCI TEST |
majunkier
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the L3 heap management to dynamically calculate heap size based on the actual IMR size reported by hardware registers instead of using hardcoded values.
Only initializes the L3 heap when the IMR is actually available and being used, as determined by the ace_imr_used() function.
This change makes the L3 heap allocation more flexible and adaptable to different hardware configurations.