Topology2: Add sof-ptl-rt722-l0-rt1320-4ch support #10166
Conversation
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt722-l0-rt1320-l23-4ch.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| BT_PCM_ID=20,BT_ID=10,BT_PCM_NAME=Bluetooth,ADD_BT=true,\ |
There was a problem hiding this comment.
Thanks for pinging @bardliao . I think we are digging ourself into a hole here. With I2S, we had clearer separate with Chromebooks (BT enabled) and other laptops (BT offload not enabled in Linux). Now with SDW, this i sno longer the case, sof-ptl-rt722-l0-rt1320-l23-4ch.tplg could for sure be used on non-Chromebooks as well and then we do have a problem as any machine that uses this SDW codec topology and doesn't have explicit quirk in the sof_sdw mach driver, will fail to load. If you install desktop Linux to a Chromebook, that's still ok, but if it's not a Chromebook design, we have a real problem.
Not sure how to solve this. I think we'd need to start adding bt suffix for any new topology and add kernel support for the BT suffix (so chromebooks quirk will add another PCM plus load a different tplg). I don't think there is way around this otherwise.
There was a problem hiding this comment.
And to add, I don't think we can rename existing topologies without breaking already shipping Chromebooks. So we need to start with new topologies (at least).
There was a problem hiding this comment.
@kv2019i Thanks for comment. I have the same thought, too. Let me try to add the BT suffix in the kernel. However, when the -bt suffix is added, it will apply to all the existing configs. In other words, the driver will look for the topology with -bt suffix, but we don't have the topologies for the existing BT configs so far.
There was a problem hiding this comment.
There was a problem hiding this comment.
@bardliao I assume this mean that this PR depends on thesofproject/linux#5518 ?
|
|
@macchian pls remove the DNM tag once kernel PR is merged. Thanks ! |
macchian
force-pushed
the
dev-rt722-rt1320
branch
3 times, most recently
from
8142eaf to
752ff0a
Compare
The topology adds support for: RT722 sdca codec on sound link 0, RT1320 left amplifier on soundwire link 2, RT1320 right amplifier on soundwire link 3, respectively, and includes PCH_DMIC and SSP2-BT support. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
dev-rt722-rt1320
branch
from
752ff0a to
c799d9f
Compare
macchian
changed the title
|
Topology not tested by internal CI, merging. |
5 participants
This topology add rt722 sdca codec on sound link 0, rt1320 left, right amplifers on soundwire link 2 and 3 without/with PCH_DMIC support.