Topology2: Add function topologies with different BE IDs #10157
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional topology configurations to support different Backend Element (BE) IDs for DMIC and HDMI interfaces when SDW BEs are present, addressing the dependency between SDW BE count and DMIC/HDMI BE ID assignment.
- Adds HDMI topology variant with ID 6 for SDW configurations
- Adds DMIC topology variants with IDs 3 and 4 for both 2-channel and 4-channel configurations across ACE1 and ACE2 platforms
- Extends support for multiple platform variants (ARL, MTL, LNL) with consistent ID patterns
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tplg-targets-sdca-generic.cmake | Adds HDMI PCM topology with ID 6 for SDW configurations |
| tplg-targets-ace2.cmake | Adds DMIC topologies with IDs 3-4 for LNL platform in 2ch and 4ch variants |
| tplg-targets-ace1.cmake | Adds DMIC topologies with IDs 3-4 for both ARL and MTL platforms in 2ch and 4ch variants |
|
In testing one of the scenarios I booted was codec-only and that attempted to load an sof-lnl-dmic-2ch-id2.tplg It's a bit of a weird one as far as products are concerned but I guess it's theoretically possible? |
bardliao
force-pushed
the
various-function-topologies
branch
from
9e7ad24 to
9a2fa17
Compare
Yes, it is possible. Updated. |
|
|
||
| "cavs-sdw\;sof-arl-dmic-4ch-id2\;PLATFORM=mtl,SDW_JACK=false,NUM_HDMIS=0,NUM_DMICS=4,\ | ||
| PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,DMIC0_ID=2,DMIC1_ID=3,PREPROCESS_PLUGINS=nhlt,\ | ||
| NHLT_BIN=nhlt-sof-arl-dmic-4ch-id3.bin" |
There was a problem hiding this comment.
Is this correct? The tplg file is named sof-arl-dmic-4ch-id2, but the NHLT .bin is nhlt-sof-arl-dmic-4ch-id3.bin ?
The DMIC BE ID could be 3 or 4 depends on how many SDW BEs are created. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
The HDMI BE ID depends on how many SDW BEs are created. Add missing BE ID 4 and 6. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
various-function-topologies
branch
from
9a2fa17 to
6eb37a4
Compare
|
@simontrimmer @jsarha pls review/approve if good for you now. Thanks! |
5 participants
The DMIC and HDMI BE IDs depends on how many SDW BEs are created. Add some missing function topologies.