-
Notifications
You must be signed in to change notification settings - Fork 349
boards: ace: power: disable unused asynchronous runtime PM #10148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: ace: power: disable unused asynchronous runtime PM #10148
Conversation
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @tmleman do we need to remove the dead code from SOF or is it in Zephyr ?
|
@tmleman is this because we never use |
This patch removes the `CONFIG_PM_DEVICE_RUNTIME_ASYNC` configuration from the Intel ADSP board files, including ACE15 MTPM, ACE20 LNL, ACE30 PTL, ACE30 WCL ACE40 NVL and ACE40 NVLS. The asynchronous runtime power management feature is not utilized by any device drivers in our project, rendering it unnecessary. By excluding this configuration, we prevent the compilation of dead code related to power management, optimizing the build process and reducing potential overhead. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
e6adeb2 to
6ab073a
Compare
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables unused asynchronous runtime power management across Intel ADSP board configurations to optimize build size and prevent compilation of dead code. The change systematically adds CONFIG_PM_DEVICE_RUNTIME_ASYNC=n to all Intel ADSP ACE board configuration files since no device drivers in the project utilize this feature.
- Adds explicit disabling of asynchronous runtime PM configuration
- Targets all Intel ADSP ACE board variants (ACE15, ACE20, ACE30, ACE40)
- Optimizes build process by excluding unused power management code
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/boards/intel_adsp_ace15_mtpm.conf | Disables async runtime PM for ACE15 MTPM board |
| app/boards/intel_adsp_ace20_lnl.conf | Disables async runtime PM for ACE20 LNL board |
| app/boards/intel_adsp_ace30_ptl.conf | Disables async runtime PM for ACE30 PTL board |
| app/boards/intel_adsp_ace30_wcl.conf | Disables async runtime PM for ACE30 WCL board |
| app/boards/intel_adsp_ace40_nvl.conf | Disables async runtime PM for ACE40 NVL board |
| app/boards/intel_adsp_ace40_nvls.conf | Disables async runtime PM for ACE40 NVLS board |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
All code is in Zephyr. |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, looks good! We can't disable configuration options via the defconfig system, so this setting must be done for each board file separately (so this PR is good).
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmleman can we remove the code too in favor of Zephyr based PM ?
@lgirdwood there's nothing to remove on the SOF side. The code is in Zephyr side. The feature is enabled by default, and we don't use it. |
|
SOFCI TEST |
This patch removes the
CONFIG_PM_DEVICE_RUNTIME_ASYNCconfiguration from the Intel ADSP board files, including ACE15 MTPM, ACE20 LNL, ACE30 PTL, ACE30 WCL ACE40 NVL and ACE40 NVLS.The asynchronous runtime power management feature is not utilized by any device drivers in our project, rendering it unnecessary. By excluding this configuration, we prevent the compilation of dead code related to power management, optimizing the build process and reducing potential overhead.