userspace: dp: Add support for userspace DP thread #10142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
force-pushed
the
userspace-dp
branch
from
de5eec1 to
027a490
Compare
softwarecki
force-pushed
the
userspace-dp
branch
from
027a490 to
453cbaf
Compare
New overlay config created to build SOF with userspace mode enabled. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com> Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Allocate task structures from the module's driver heap to enable userspace access. This change allows the DP task to operate in userspace context. Also update LL task allocation to use the same heap for consistency, as the memory release logic is shared and does not differentiate between heaps. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
userspace-dp
branch
from
453cbaf to
a65241d
Compare
softwarecki
requested review from
LaurentiuM1234,
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
lyakh,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces initial support for running SOF modules in userspace, enabling selected modules to execute in non-privileged mode. The changes focus on adapting the DP scheduler for userspace compatibility and establishing the necessary memory management infrastructure.
- Modifies DP scheduler to use semaphores instead of IRQ locks for userspace threads
- Introduces userspace-specific memory domains and allocation strategies
- Adds configuration options and overlay support for userspace mode
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zephyr/lib/userspace_helper.c | Implements userspace stack allocation and memory domain management functions |
| zephyr/include/rtos/userspace_helper.h | Defines userspace helper APIs and memory partition macros |
| zephyr/Kconfig | Adds USERSPACE dependencies to heap configuration options |
| src/schedule/zephyr_dp_schedule.c | Major refactoring to support both kernel and userspace thread scheduling |
| src/include/sof/schedule/dp_schedule.h | Updates scheduler API to include thread options parameter |
| src/include/sof/audio/module_adapter/library/userspace_proxy.h | Defines userspace context structure |
| src/include/module/module/base.h | Adds userspace context field to processing module |
| src/include/sof/audio/component_ext.h | Updates component cleanup to use module heap |
| src/idc/idc.c | Converts IDC task allocation to use module heap |
| src/audio/pipeline/pipeline-schedule.c | Updates DP task creation with userspace support |
| src/audio/buffers/comp_buffer.c | Adds memory partition annotations to buffer operations |
| app/overlays/ptl/userspace_overlay.conf | Provides userspace-specific configuration overlay |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
softwarecki
commented
Sep 5, 2025
Collaborator
Author
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
Resolved incorrect review comments generated by the AI copilot.
kv2019i
reviewed
Sep 8, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
No showstoppers -- minor comments inline
lgirdwood
approved these changes
Sep 8, 2025
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
I think this is a good 1st step we can build on.
softwarecki
force-pushed
the
userspace-dp
branch
from
a65241d to
c4d573d
Compare
Collaborator
|
@softwarecki do I understand it correctly that with this PR it's possible to run a DP module in user space? We really need a CI test for this... |
kv2019i
approved these changes
Sep 10, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Bonus if you add the one ifdef USERSPACE but not a blocker.
Introduce the userspace_context structure to store data required by modules operating in userspace. Add the common_partition memory domain to share SOF components that need to be accessible from userspace. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
userspace-dp
branch
from
c4d573d to
612ab6c
Compare
K_USER option flag is ignored until CONFIG_USERSPACE is not set. When set, it creates thread in non_priviledged mode. Without proper support such thread will fail. This change is required to run DP scheduler with CONFIG_USERSPACE flag set. When DP scheduler supports non-privileged modules use of irq_lock is not allowed. Therefore for this configuration it uses static semaphores one per core. These could be accesses from user space thread. New created thread with K_USER option (non-privileged) must be added to module memory domain to get access to its private memory space. Additionally allocate scheduler data and task_memory from shared pool. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com> Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
userspace-dp
branch
from
612ab6c to
73abfd8
Compare
tmleman
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces initial support for running SOF modules in userspace. Key changes include:
DP Scheduler Adaptation: Modify the DP scheduler to operate with
CONFIG_USERSPACEenabled. Replaceirq_lockwith per-core static semaphores for non-privileged threads.Userspace Context: Add
userspace_contextstructure to manage userspace-specific data.Memory Domain: Introduce
common_partitionmemory domain to expose selected SOF components to userspace.Task Allocation: Allocate DP and LL task structures from the module driver heap to ensure compatibility with userspace access.
Overlay Configuration: Add userspace-specific overlay config to enable building SOF in userspace mode.
Manifest Update: Synchronize
man_module_typewith reference FW to support new fields likeuser_mode,domain_rtos, andcore_type.These changes lay the groundwork for executing selected SOF modules in non-privileged mode.