Skip to content

ipc4: remove needless interrupt disabling #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lyakh wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ipc4: remove needless interrupt disabling #10125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/ipc/ipc4/helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,14 +963,10 @@ __cold static const struct comp_driver *ipc4_get_drv(const void *uuid)
const struct sof_uuid *const __maybe_unused sof_uuid = (const struct sof_uuid *)uuid;
struct comp_driver_list *drivers = comp_drivers_get();
struct list_item *clist;
const struct comp_driver *drv = NULL;
struct comp_driver_info *info;
uint32_t flags;

assert_can_be_cold();

irq_local_disable(flags);

/* search driver list with UUID */
list_for_item(clist, &drivers->list) {
info = container_of(clist, struct comp_driver_info,
Expand All @@ -980,20 +976,17 @@ __cold static const struct comp_driver *ipc4_get_drv(const void *uuid)
"found type %d, uuid %pU",
info->drv->type,
info->drv->tctx->uuid_p);
drv = info->drv;
goto out;
return info->drv;
}
}

tr_warn(&comp_tr,
"get_drv(): the provided UUID (%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x) can't be found!",
"the provided UUID (%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x) can't be found!",
sof_uuid->a, sof_uuid->b, sof_uuid->c, sof_uuid->d[0], sof_uuid->d[1],
sof_uuid->d[2], sof_uuid->d[3], sof_uuid->d[4], sof_uuid->d[5], sof_uuid->d[6],
sof_uuid->d[7]);

out:
irq_local_enable(flags);
return drv;
return NULL;
}

/*
Expand Down
Loading