WCL BEP CS42l43 Topology #10078
Merged
WCL BEP CS42l43 Topology #10078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen-manohar
requested review from
RanderWang,
abonislawski,
dbaluta,
jsarha,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko,
plbossart,
ranj063,
singalsu and
tlissows
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the cs42l43-sdw topology and updates platform configurations accordingly. Key changes include updating repository revisions in west.yml and versions.json, adding new topology entries in the CMake file, and modifying various configuration and TOML files to use the new CONFIG_SOC_INTEL_ACE30 and WILDCATLAKE identifiers.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| west.yml | Updated zephyr repository revision and remote for cs42l43 support |
| versions.json | Incremented the SOF MICRO version |
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Added new SDW topology entries for cs42l43-sdw devices |
| tools/rimage/config/wcl.toml.h | Added new module entries to the configuration |
| tools/rimage/config/platform.toml | Updated platform include directive to use CONFIG_SOC_INTEL_ACE30 |
| Various *.toml files | Updated conditional definitions (from CONFIG_PANTHERLAKE to CONFIG_SOC_INTEL_ACE30) to reflect the new platform configuration |
| src/platform/Kconfig | Added configuration for WILDCATLAKE and updated default core counts |
| scripts/xtensa-build-zephyr.py | Added new PlatformConfig entries for wcl and wcl-sim platforms |
| app/sample.yaml, app/overlays/wcl/fpga_overlay.conf, app/boards/* | Added new board definitions and configuration files for the wcl platform |
bardliao
reviewed
Jun 30, 2025
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-cs42l43-l3-4ch.bin" | ||
|
|
Collaborator
There was a problem hiding this comment.
The cs42l43 DMIC will not be used when the PCH DMIC is used, right? We need to set SDW_DMIC=0 and need a DMI quirk in sof_sdw_quirk_table[] to disable the SDW DMIC. Then update the BE IDs here.
Contributor
Author
There was a problem hiding this comment.
ACK !!
Done. have re-spined patch
Adding topology support for cs42l43-sdw monolithic codec at l3 Verified on ptl & wcl-bep platforms for configuration: 1. sof-ptl-cs42l43-l3: uses SDW-DMIC 2. sof-ptl-cs42l43-l3-4ch: uses PCH-DMIC Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
force-pushed
the
wcl_cs42l43_bep
branch
from
dbe7d47 to
ac92c7d
Compare
bardliao
approved these changes
Jun 30, 2025
kv2019i
approved these changes
Jul 1, 2025
kv2019i
merged commit 35335b5
into
thesofproject:wcl-001-drop-stable
25 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topology2: add support for cs42l43-sdw topology
Adding topology support for cs42l43-sdw monolithic codec at l3
Verified on ptl & wcl-bep platforms for configuration:
md5sum sof-ptl-cs42l43-l3-4ch.tplg 1c1b8eb8758a1827bc8f9748826496a8
md5sum sof-ptl-cs42l43-l3.tplg fa54c27123619df1bfff47c8f2bad3d4