Topology2: add fragment sdca amp feedback topologies #10049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds two new SDCA amp feedback topologies to the generic SDCA targets list, enabling single- and dual-amp feedback configurations.
- Introduce
sof-sdca-1amp-feedback-id3with feedback enabled - Introduce
sof-sdca-2amp-feedback-id3with feedback enabled
| "cavs-sdw\;sof-sdca-2amp-id2\;NUM_SDW_AMP_LINKS=2,SDW_JACK=false,\ | ||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,NUM_HDMIS=0" | ||
|
|
||
| "cavs-sdw\;sof-sdca-1amp-feedback-id3\;NUM_SDW_AMP_LINKS=1,SDW_JACK=false,\ |
There was a problem hiding this comment.
Both new entries use id3, which conflicts with each other. Topology IDs should be unique to avoid target collisions—consider renaming one of them (e.g., id4).
Comment on lines
17
to
22
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp,\ | ||
| SDW_AMP_FEEDBACK=true,NUM_HDMIS=0" | ||
|
|
||
| "cavs-sdw\;sof-sdca-2amp-feedback-id3\;NUM_SDW_AMP_LINKS=2,SDW_JACK=false,\ | ||
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp,\ | ||
| SDW_AMP_FEEDBACK=true,NUM_HDMIS=0" |
There was a problem hiding this comment.
[nitpick] The property order deviates from existing entries. Reordering to match other target lines (e.g., grouping playback then feedback vars consistently) can improve readability.
Suggested change
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp,\ | |
| SDW_AMP_FEEDBACK=true,NUM_HDMIS=0" | |
| "cavs-sdw\;sof-sdca-2amp-feedback-id3\;NUM_SDW_AMP_LINKS=2,SDW_JACK=false,\ | |
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp,\ | |
| SDW_AMP_FEEDBACK=true,NUM_HDMIS=0" | |
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_AMP_FEEDBACK=true,\ | |
| SDW_SPK_IN_STREAM=Capture-SmartAmp,NUM_HDMIS=0" | |
| "cavs-sdw\;sof-sdca-2amp-feedback-id3\;NUM_SDW_AMP_LINKS=2,SDW_JACK=false,\ | |
| SDW_SPK_STREAM=Playback-SmartAmp,SDW_AMP_FEEDBACK=true,\ | |
| SDW_SPK_IN_STREAM=Capture-SmartAmp,NUM_HDMIS=0" |
Add fragment sdca amp feedback topologies. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
topology2-amp-feedback
branch
from
52a90c6 to
28ea88b
Compare
Member
|
Adding @rfvirgil and @charleskeepax |
Collaborator
Author
|
closing for now. Will reopen if we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fragment sdca amp feedback topologies.