tests: add option to test with pipewire #1296

ekurdybx · 2025-08-13T09:20:09Z

Added option to use pipewire instead of ALSA direct mode in tests, that can be turned on by setting TEST_WITH_PIPEWIRE=true. Added pipewire-wrapper, to run in SOF CI.
Currently only test that can run on pipewire is check-perfomance.sh (runs aplay/arecord on one of each types of sinks/sources).

sofci · 2025-08-13T09:23:41Z

Can one of the admins verify this patch?

reply test this please to run this test once

marc-hb

So far, sof-test was 97% portable across distributions. I used to run sof-test on Fedora without any issue. I'm concerned pipewire is going to change that. It's OK to add Debian or Ubuntu-specific bits, however:

they must remain optional (it looks like they are now, great, keep it that way)
you should try to identify and name differently the parts that are distro-specific versus pipewire standards.

case-lib/lib.sh

test-case/check-performance.sh

case-lib/lib.sh

README.md

marc-hb

Don't share fixup commits

https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

case-lib/lib.sh

test-case/pipewire-wrapper.sh

test-case/check-performance.sh

case-lib/lib.sh

test-case/check-performance.sh

case-lib/lib.sh

README.md

redzynix

In general all's good, please just add small improvements from my comments.

case-lib/lib.sh

test-case/pipewire-wrapper.sh

marc-hb · 2025-09-15T15:35:51Z

You have just pushed 2 merge commits:

marc-hb · 2025-09-18T01:10:45Z

README.md

  - SOF_ALSA_OPTS contains optional parameters passed on both play and record.
  - SOF_APLAY_OPTS and SOF_ARECORD_OPTS contain optional parameters passed additionally on play and record respectively.
 These options are applied to the selected tool (alsa or tinyalsa) based on the value of SOF_ALSA_TOOL 
+  - SOF_TEST_PIPEWIRE (default: false) allows to use pipewire instead of ALSA direct mode. Currently only works with check-performance.sh.


Suggested change

- SOF_TEST_PIPEWIRE (default: false) allows to use pipewire instead of ALSA direct mode. Currently only works with check-performance.sh.

- SOF_TEST_PIPEWIRE (default: false) allows to use pipewire instead of ALSA direct mode. Supported by a limited number of tests, try something like `git grep SOF_TEST_PIPEWIRE` to find which one(s).

marc-hb · 2025-09-18T01:12:15Z

case-lib/hijack.sh

    dlogi "Starting func_exit_handler($exit_status)"

+    if [ "$SOF_TEST_PIPEWIRE" == true ]; then
+        func_lib_disable_pipewire


Why did you mark this comment as "resolved" without any code change or answer?

https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers

Marking all comments as resolved is not necessary before merge.

majunkier · 2025-09-18T07:23:28Z

please add commit description

ekurdybx · 2025-09-18T07:49:53Z

You have just pushed 2 merge commits:

My mistake, fixed that

marc-hb

There could some minor issues left (including at least one below) but they can be fixed later.

On the other hand, this should really be run in jenkins. @ekurdybx your https://github.com/orgs/thesofproject/teams/sof-developers membership is way overdue. Please ask someone in https://github.com/orgs/thesofproject/teams/sof-developers?query=role%3Amaintainer . You probably can't see that link but most of your coworkers can.

marc-hb · 2025-09-20T03:36:12Z

case-lib/lib.sh

+    dlogi "Check if pipewire is running"
+
+    # shellcheck disable=SC2015
+    systemctl is-active --user --quiet pipewire{,-pulse}.{socket,service} && func_lib_disable_pipewire || dlogi "Pipewire not running"


A && B || C is not equivalent to if A; then B; else C; fi, this is a very common misconception. Compare:

if true; then grep notfound /etc/passwd ; else 'ELSE is not run'; fi true && grep notfound /etc/passwd || echo 'ELSE is also run!!'

(from #312)

Add option to use pipewire instead of ALSA direct mode in tests. Currently works only with check-performance.sh - runs aplay/arecord on each type of pipewire sink/source. Added pipewire-wrapper.sh to run with SOF CI. Signed-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>

ekurdybx · 2025-09-22T07:40:41Z

There could some minor issues left (including at least one below) but they can be fixed later.

On the other hand, this should really be run in jenkins. @ekurdybx your github.com/orgs/thesofproject/teams/sof-developers membership is way overdue. Please ask someone in github.com/orgs/thesofproject/teams/sof-developers?query=role%3Amaintainer . You probably can't see that link but most of your coworkers can.

This was run in jenkins, I tested this on lnlm, ptlh and mtlp platforms, it works as expected.

marc-hb · 2025-09-22T18:04:38Z

This was run in jenkins, I tested this on lnlm, ptlh and mtlp platforms, it works as expected.

I just realized none of the sof-test Pull Requests show Jenkins results any more, it's not specific to this particular PR. I mean, there is no sof-test Pull Request that has test results like this:

https://sof-ci.01.org/sofpr/PR10251/build15809/devicetest/index.html

@ekurdybx , @cgturner1 could you investigate this?

marc-hb · 2025-09-22T18:28:19Z

Just proving myself wrong 10 min later, some jenkins results are now showing up in #1303

However I had to allow them manually with the magic sentence. I should not have to, please get https://github.com/orgs/thesofproject/teams/sof-developers membership yesterday.

This was run in jenkins, ...

I suspected some publication / permission issue but based on this #1303 screenshot it does not look like this PR #1296 was run in jenkins. At least not in the "regular" jenkins like the one running #1303 above.

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from eaa6172 to 64c96c8 Compare August 13, 2025 09:23

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 2 times, most recently from 4670555 to 6810df4 Compare August 13, 2025 09:55

ekurdybx changed the title ~~test: add option to test with pipewire~~ tests: add option to test with pipewire Aug 13, 2025

marc-hb mentioned this pull request Aug 13, 2025

Pulseaudio/pipewire coverage #91

Open

6 tasks

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 2 times, most recently from 9c63bbb to a867076 Compare August 14, 2025 12:33

ekurdybx marked this pull request as ready for review August 14, 2025 12:37

ekurdybx requested review from a team, golowanow, lgirdwood and marc-hb as code owners August 14, 2025 12:37

marc-hb reviewed Aug 14, 2025

View reviewed changes

case-lib/lib.sh Show resolved Hide resolved

case-lib/lib.sh Outdated Show resolved Hide resolved

marc-hb reviewed Aug 14, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

marc-hb reviewed Aug 25, 2025

View reviewed changes

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 3 times, most recently from 1aa0aa5 to dae8d46 Compare August 26, 2025 13:29

marc-hb reviewed Aug 26, 2025

View reviewed changes

case-lib/lib.sh Outdated Show resolved Hide resolved

case-lib/lib.sh Show resolved Hide resolved

case-lib/lib.sh Outdated Show resolved Hide resolved

test-case/check-performance.sh Show resolved Hide resolved

case-lib/lib.sh Outdated Show resolved Hide resolved

marc-hb reviewed Aug 26, 2025

View reviewed changes

case-lib/lib.sh Show resolved Hide resolved

case-lib/lib.sh Show resolved Hide resolved

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 6 times, most recently from ae00d7b to 20e4244 Compare August 28, 2025 10:50

marc-hb reviewed Aug 28, 2025

View reviewed changes

case-lib/lib.sh Outdated Show resolved Hide resolved

case-lib/lib.sh Outdated Show resolved Hide resolved

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 20e4244 to 9d24ad2 Compare August 29, 2025 09:18

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 9d24ad2 to bdcebcf Compare September 1, 2025 08:03

PLangowski reviewed Sep 1, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from bdcebcf to 9a92625 Compare September 1, 2025 08:48

redzynix reviewed Sep 1, 2025

View reviewed changes

case-lib/lib.sh Outdated Show resolved Hide resolved

case-lib/lib.sh Outdated Show resolved Hide resolved

test-case/pipewire-wrapper.sh Outdated Show resolved Hide resolved

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 9a92625 to e9eb1f7 Compare September 1, 2025 09:42

redzynix approved these changes Sep 1, 2025

View reviewed changes

redzynix reviewed Sep 3, 2025

View reviewed changes

test-case/pipewire-wrapper.sh Outdated Show resolved Hide resolved

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 3 times, most recently from cfc984c to ca3ff6b Compare September 10, 2025 13:26

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 2 times, most recently from 55052ec to 4e554c3 Compare September 12, 2025 12:31

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch 2 times, most recently from 4e554c3 to 054f9dd Compare September 16, 2025 07:35

majunkier requested a review from marc-hb September 17, 2025 09:28

marc-hb reviewed Sep 18, 2025

View reviewed changes

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 054f9dd to 3b53cb2 Compare September 18, 2025 07:13

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 3b53cb2 to 03e45f2 Compare September 18, 2025 07:40

majunkier approved these changes Sep 18, 2025

View reviewed changes

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 03e45f2 to 1622cb5 Compare September 19, 2025 13:28

marc-hb reviewed Sep 20, 2025

View reviewed changes

ekurdybx force-pushed the SOFC2-801-add-pipewire-test-option branch from 1622cb5 to ad761ca Compare September 22, 2025 07:36

redzynix merged commit d4ea109 into thesofproject:main Sep 22, 2025
3 checks passed

	- SOF_TEST_PIPEWIRE (default: false) allows to use pipewire instead of ALSA direct mode. Currently only works with check-performance.sh.
	- SOF_TEST_PIPEWIRE (default: false) allows to use pipewire instead of ALSA direct mode. Supported by a limited number of tests, try something like `git grep SOF_TEST_PIPEWIRE` to find which one(s).

tests: add option to test with pipewire #1296

tests: add option to test with pipewire #1296

Uh oh!

Conversation

ekurdybx commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sofci commented Aug 13, 2025

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

redzynix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc-hb commented Sep 15, 2025

Uh oh!

marc-hb Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

ekurdybx Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

marc-hb Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

majunkier commented Sep 18, 2025

Uh oh!

ekurdybx commented Sep 18, 2025

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

marc-hb Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

ekurdybx Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

ekurdybx commented Sep 22, 2025

Uh oh!

Uh oh!

marc-hb commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

ekurdybx commented Aug 13, 2025 •

edited

Loading

marc-hb commented Sep 22, 2025 •

edited

Loading

marc-hb commented Sep 22, 2025 •

edited

Loading