test-case/check-audio-equalizer.sh: Restore config after test #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLangowski
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
redzynix
approved these changes
Jul 28, 2025
PLangowski
force-pushed
the
equalizer-reset
branch
from
7fe64cc to
53c4d5a
Compare
marc-hb
reviewed
Jul 29, 2025
PLangowski
force-pushed
the
equalizer-reset
branch
from
53c4d5a to
1c931e6
Compare
golowanow
reviewed
Aug 1, 2025
PLangowski
force-pushed
the
equalizer-reset
branch
from
1c931e6 to
d4a05f4
Compare
Contributor
Author
|
@golowanow I applied your suggestions. Could you take a look again? |
marc-hb
reviewed
Aug 5, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Minor codestyle suggestions
test-case/check-audio-equalizer.sh
Outdated
|
|
||
| if [ $ret -ne 0 ]; then | ||
| dloge "Equalizer test failure with $conf" | ||
| return 1 |
Collaborator
There was a problem hiding this comment.
[ "$ret" -eq 0 ] || die ...
PLangowski
force-pushed
the
equalizer-reset
branch
from
d4a05f4 to
2f95066
Compare
Contributor
Author
|
@marc-hb Fixed, could you look again? |
marc-hb
approved these changes
Aug 6, 2025
test-case/check-audio-equalizer.sh
Outdated
|
|
||
| sof-ctl -Dhw:"$sofcard" -c name="$double_quoted_id" -s "$eq_last_conf" || die "Failed to restore equalizer config from $eq_last_conf" | ||
|
|
||
| [ "$ret" -eq 0 ] || die "Equalizer test failure with $conf" |
Collaborator
There was a problem hiding this comment.
Suggested change
| [ "$ret" -eq 0 ] || die "Equalizer test failure with $conf" | |
| [ "$ret" -eq 0 ] || die "$cmd with $conf returned $ret" |
golowanow
reviewed
Aug 7, 2025
test-case/check-audio-equalizer.sh
Outdated
Comment on lines
68
to
75
| $cmd -D "$dev" -f "$fmt" -c "$channel" -r "$rate" -d "$duration" "$dummy_file" || ret=$? | ||
|
|
||
| [ -r "$eq_last_conf" ] || | ||
| die "Failed to read equalizer config from $eq_last_conf" | ||
|
|
||
| sof-ctl -Dhw:"$sofcard" -c name="$double_quoted_id" -s "$eq_last_conf" || die "Failed to restore equalizer config from $eq_last_conf" | ||
|
|
||
| [ "$ret" -eq 0 ] || die "Equalizer test failure with $conf" |
Member
There was a problem hiding this comment.
Suggested change
| $cmd -D "$dev" -f "$fmt" -c "$channel" -r "$rate" -d "$duration" "$dummy_file" || ret=$? | |
| [ -r "$eq_last_conf" ] || | |
| die "Failed to read equalizer config from $eq_last_conf" | |
| sof-ctl -Dhw:"$sofcard" -c name="$double_quoted_id" -s "$eq_last_conf" || die "Failed to restore equalizer config from $eq_last_conf" | |
| [ "$ret" -eq 0 ] || die "Equalizer test failure with $conf" | |
| $cmd -D "$dev" -f "$fmt" -c "$channel" -r "$rate" -d "$duration" "$dummy_file" || ret=$? | |
| [ -r "$eq_last_conf" ] || | |
| die "Failed to read equalizer config from $eq_last_conf" | |
| sof-ctl -Dhw:"$sofcard" -c name="$double_quoted_id" -s "$eq_last_conf" || die "Failed to restore equalizer config from $eq_last_conf" | |
| [ "$ret" -eq 0 ] || return 1 |
to keep the current expectation at the caller function.
Member
|
@PLangowski - I don't see results from this changed test probe on our CI, please run it there and let me know where to check. |
Save the initial equalizer config to a temporary file and restore it after each test Signed-off-by: Pawel Langowski <pawelx.langowski@intel.com>
PLangowski
force-pushed
the
equalizer-reset
branch
from
2f95066 to
b65cd74
Compare
Contributor
Author
|
@golowanow I'm not sure if it's possible to run a test on CI before merging it. Do you know how to do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the equalizer config to its previous state after test