-
Notifications
You must be signed in to change notification settings - Fork 59
test-case: latency-metrics: introduce latency tests #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0ade14 to
4dd2fba
Compare
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code style suggestions, all the rest LGTM.
Some audio expert must review the actual logic, I did not.
42bb830 to
7d8cb92
Compare
|
25/May changes:
|
7d8cb92 to
a24e684
Compare
|
26/May changes (should be the last significant change in this PR):
|
a24e684 to
279904e
Compare
|
27/May changes: |
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, some audio expert should review the logic.
279904e to
eaa2550
Compare
|
28/May changes - address review comments:
|
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some audio expert must review.
eaa2550 to
9b8e682
Compare
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @golowanow , looks great! Good comments in code, this will be good basis to build on other tests.
Introduce latency tests using `JACK` Audio Connection Kit: run `jackd` audio service, connect ports with loopback and run `jack_iodelay` to collect latency measurements, detect xrun-s, calculate and save statistics into a json report file. Optionally, run in 'trial' mode repeating measurements with gradually reduced buffers to find the smallest latency possible. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
9b8e682 to
5e6e96b
Compare
|
SOFCI TEST |
Introduce latency tests using
JACKAudio Connection Kit:run
jackdaudio service, connect ports with loopback and runjack_iodelayto collect latency measurements, calculate and save statistics in a json report file.