Skip to content

Conversation

@gbarkadiusz
Copy link
Contributor

@gbarkadiusz gbarkadiusz commented May 15, 2025

Set SOF_ALSA_TOOL variable to a default value globally.
Justification:
After tinyalsa support was added (PR #1260), the use of SOF_ALSA_TOOL is now required for all tests before calling the aplay_opt or arecord_opt functions from lib.sh.

@gbarkadiusz gbarkadiusz requested review from a team, golowanow, lgirdwood and marc-hb as code owners May 15, 2025 09:17
@golowanow
Copy link
Member

Refactor the multiple-pipline.sh to use initialize_audio_params function.

Justification: After tinyalsa support was added (PR #1260), tests must set the $SOF_ALSA_TOOL variable before calling the aplay_opt or arecord_opt functions from lib.sh. The default value (alsa) for $SOF_ALSA_TOOL is set in the initialize_audio_params function.

Please don't mix 'fix' and 'refactor' purposes.

As a fix it is better to treat $SOF_ALSA_TOOL not defined as default 'alsa', or set $SOF_ALSA_TOOL 'alsa' default globally.
This way it should work for any test case not 'refactored' yet.

@gbarkadiusz
Copy link
Contributor Author

Refactor the multiple-pipline.sh to use initialize_audio_params function.
Justification: After tinyalsa support was added (PR #1260), tests must set the $SOF_ALSA_TOOL variable before calling the aplay_opt or arecord_opt functions from lib.sh. The default value (alsa) for $SOF_ALSA_TOOL is set in the initialize_audio_params function.

Please don't mix 'fix' and 'refactor' purposes.

As a fix it is better to treat $SOF_ALSA_TOOL not defined as default 'alsa', or set $SOF_ALSA_TOOL 'alsa' default globally. This way it should work for any test case not 'refactored' yet.

WIP.

Set SOF_ALSA_TOOL to default value (alsa) globally.

Signed-off-by: Arkadiusz Cholewinski <arkadiuszx.cholewinski@intel.com>
@gbarkadiusz gbarkadiusz force-pushed the topic/fix_multiple_pipline_test branch from d76cad8 to 413ba88 Compare May 15, 2025 09:29
@gbarkadiusz gbarkadiusz changed the title Fix: Refactor the multiple-pipline.sh Fix: Set SOF_ALSA to default value globally. May 15, 2025
@golowanow
Copy link
Member

Please make this PR as a fix only which works for all test case scripts and do 'refactoring' as a separate Pr (see also check-performance.sh)

@golowanow golowanow added type:bug Something doesn't work as expected P2 Critical bugs or normal features labels May 15, 2025
@golowanow
Copy link
Member

LGTM, but lets wait for test results

@gbarkadiusz gbarkadiusz changed the title Fix: Set SOF_ALSA to default value globally. Fix: Set SOF_ALSA_TOOL to default value globally. May 15, 2025
@gbarkadiusz gbarkadiusz requested a review from redzynix May 15, 2025 11:48
@cgturner1 cgturner1 merged commit fdd7ae4 into thesofproject:main May 15, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Critical bugs or normal features type:bug Something doesn't work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants