TinyAlsa: Add support for tinymix command. #1267
Conversation
gbarkadiusz
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
b5fb40c to
3babfd8
Compare
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
2 times, most recently
from
b06b352 to
3f42c3e
Compare
golowanow
left a comment
golowanow
left a comment
There was a problem hiding this comment.
Please change commit/PR description: this PR adds tinymix support at one test only.
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
3f42c3e to
7a9ad24
Compare
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I did not carefully scrutinize every single line but it Looks Good To Me.
golowanow
left a comment
golowanow
left a comment
There was a problem hiding this comment.
please look through what remains of my comments not resolved/answered here yet
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
2 times, most recently
from
4103f2f to
aed0992
Compare
golowanow
left a comment
golowanow
left a comment
There was a problem hiding this comment.
Please change commit/PR description: this PR adds tinymix support at one test only.
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
aed0992 to
aab8622
Compare
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
aab8622 to
c60cff6
Compare
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
c60cff6 to
37c01ea
Compare
golowanow
left a comment
golowanow
left a comment
There was a problem hiding this comment.
LGTM,
waiting for CI results with ipc4. Would be nice to see a tinyalsa probe run as well.
Please change the commit's summary line aligned to its description and the actual change, e.g.:
volume_basic_test: add TinyALSA mode
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
2 times, most recently
from
53e7d8b to
dbd19fd
Compare
I've changed the title to: |
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
dbd19fd to
90caf71
Compare
Refactor the volume_basic_test to use lib.sh instead of calling ALSA commands directly, and add support for the tinymix command from TinyALSA. Signed-off-by: Arkadiusz Cholewinski <arkadiuszx.cholewinski@intel.com>
gbarkadiusz
force-pushed
the
topic/add_tinymix_support
branch
from
90caf71 to
5c76734
Compare
3 participants
The goal is to modify
volume_basic_testto use the utilities inlib.shfor ALSA operations, rather than directly invokingamixeror other ALSA commands. This makes the test more robust and maintainable. Additionally, it'll introduce support fortinymixfrom TinyAlsa, but only within this particular test.