Skip to content

Conversation

@mohsinkh30
Copy link
Contributor

alsa_settings/PTLP_RVP_SDW.sh: Modified alsabat mixer settings with respect to UCM2 file for PTL SDW RT722"

…ect to UCM2 file for PTL SDW RT722

Signed-off-by: mohsinkh30 <mohsin.khan@intel.com>
@mohsinkh30 mohsinkh30 requested review from a team, golowanow, lgirdwood and marc-hb as code owners March 14, 2025 08:59
@sofci
Copy link
Collaborator

sofci commented Mar 14, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

@golowanow
Copy link
Member

golowanow commented Mar 14, 2025

@mohsinkh30 do we have a CI probe run with this change already ?
ok, I see there is a probe run (50963) already and for all check-alsabat-headset-* cases there it has

WARNING: Signal too weak!
WARNING: Signal too weak!

i wonder is it expected and the new settings work reliable enough ?

Copy link
Contributor

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good.

The git commit message is not following common style. The summary line should be with 72 characters and there should be a paragraph explaining the change. Your git user name is also not entirely correct.

Not blocker for sof-test, but please note in future PRs.

@kv2019i
Copy link
Contributor

kv2019i commented Mar 14, 2025

@golowanow It's true the volume is very low:

Channel 1 - Checking for target frequency 599.00 Hz
Amplitude: 175.2; Percentage: [0]
Detected peak at 599.12 Hz of 38.21 dB

Still better than clipping, so I'm ok to fine-tune later.

@golowanow golowanow merged commit f0f82d0 into thesofproject:main Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants